Bug 55028 - Make Subject of self service mails configurable (via UCR)
Make Subject of self service mails configurable (via UCR)
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Self Service
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-2-errata
Assigned To: Maximilian Janßen
Florian Best
:
Depends on: 53227
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-25 17:00 CEST by Dirk Schnick
Modified: 2022-10-06 09:49 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?: Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2021050321000371
Bug group (optional): bitesize
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schnick univentionstaff 2022-07-25 17:00:26 CEST
In the original Bug (Feature Request) I ment all subjects of the all self service mails. In the first bug only password reset mail subjects became configurable.

Please make all mails of the self service configureable. A customer reported:

verification_email_body
email_change_notification_email_body
email_body
deregistration_notification_email_body

Is hardcoded in english. Please verify that subject and body of all self service mails can be configured.


+++ This bug was initially created as a clone of Bug #53227 +++

A customer wants to customize the reset mails of the self service. Body works fine but as far as I an see in the code the subject is hard coded.

/usr/lib/python2.7/dist-packages/univention/management/console/modules/passwordreset/sending/send_email.py -> line 114

msg["Subject"] = "Password reset"

It would be fine if this is also customizable via UCR like the body.
Comment 1 Florian Best univentionstaff 2022-07-27 10:20:03 CEST
We should also add the new UCR variables to the self service manual.
Comment 2 Nico Gulden univentionstaff 2022-07-27 10:25:43 CEST
The content is missing at https://docs.software-univention.de/manual/5.0/en/user-management/user-self-service.html
Comment 3 Florian Best univentionstaff 2022-09-28 09:37:25 CEST
The changes raise an exception:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/passwordreset/__init__.py", line 892, in _deregister_account
    self._notify_about_account_deregistration(user.props.username, user.props.PasswordRecoveryEmail)
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/passwordreset/__init__.py", line 913, in _notify_about_account_deregistration
    msg["Subject"] = self.ucr.get("umc/self-service/account-deregistration/email/subject", "Account deletion")
AttributeError: 'Instance' object has no attribute 'ucr'
Comment 4 Maximilian Janßen univentionstaff 2022-09-30 15:26:02 CEST
univention-self-service.yaml
908298f89cc5 | Bug #55028: yaml
491a90fabc2a | Bug #55028: univention-self-service
e55ae2a88269 | Bug #55028: add ucr variables to customize mail subjects of the deregistration, account-verification, and email-change email

univention-self-service (5.0.2-3)
ca1489bfafd9 | fixup! Bug #55028: add ucr variables to customize mail subjects of the deregistration, account-verification, and email-change email
e55ae2a88269 | Bug #55028: add ucr variables to customize mail subjects of the deregistration, account-verification, and email-change email
Comment 5 Florian Best univentionstaff 2022-10-04 11:43:30 CEST
OK: subject of 3 other emails are now configurable
OK: YAML