Description Florian Best 2022-07-27 13:08:37 CEST

git:da06afda8d4c64db2c1ce2fea6b78ac4fb51ac80 introduced an `=*` operator for univention.admin.filter.expression.

So `univention.admin.filter.parse('foo=*')` results in `expression('foo', '', '=*')` instead of `expression('foo', '*', '=')`.

This change had side effects on the UDM filter generation.

Now dead code:
> modules/univention/admin/handlers/users/user.py:                        elif filter.value == u'*'
> modules/univention/admin/handlers/__init__.py:          if filter.value == '*' and property_ and issubclass(property_.syntax if inspect.isclass(property_.syntax) else type(property_.syntax), (univention.admin.syntax.IStates, univention.admin.syntax.boolean)):

Probably affected (no substring search is done anymore, so no search result is found anymore):
> modules/univention/admin/handlers/dhcp/pool.py:                 filter.value = '%s %s' % (filter.value.strip('*'), cls.permits_udm2dhcp[filter.variable])

Maybe affected:
> modules/univention/admin/handlers/users/user.py:                                userexpiry_filter = filter_format(u'(|(shadowExpire=%s)(krb5ValidEnd=%s)(sambaKickoffTime=%s))', [filter.value or '*', filter.value or '*', filter.value or '*'])

And also general different behavior:

`udm policies/registry list --filter 'registry=*'` creates `(&(objectClass=univentionPolicyRegistry)(registry=*[['']]))`  instead of `(&(objectClass=univentionPolicyRegistry)(registry=[['*']]))` - yes, both is broken but that's a different bug. There are probably also cases with valid output.

1. we have to ensure consistent behavior.
`univention.admin.filter.parse('foo=*')`, `expression('foo', '', '=*')` and `expression('foo', '*', '=')` should result in the same expression.

2. we have to fix the broken searches due to this change.