Bug 55063 - Portal still has code from "six"
Portal still has code from "six"
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Portal
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-2-errata
Assigned To: Mika Westphal
Florian Best
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2022-08-03 14:49 CEST by Dirk Wiesenthal
Modified: 2022-08-31 12:19 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 5: Will affect all installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.057
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): bitesize
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2022-08-03 14:49:29 CEST
We still import and use six in the portal library.

But we do not provide any python2 version of the library, so it does not bring any benefit. And the code between UCS 4.4 and UCS 5 changed so dramatically that it is not helpful for backporting fixes.

Even more problematic: We do not mention six in debian/changelog.

Please remove the six code in the portal.
Comment 1 Dirk Wiesenthal univentionstaff 2022-08-03 14:50:26 CEST
(In reply to Dirk Wiesenthal from comment #0)
> Even more problematic: We do not mention six in debian/changelog.

I meant debian/control
Comment 2 Mika Westphal univentionstaff 2022-08-25 13:30:17 CEST
All occurrences of six have been removed.

univention-portal.yaml
77efe21740a8 | Bug #55063: YAML
477dc12535f8 | Bug #55063: removed dependency and use of python-six

univention-portal (4.0.7-9)
477dc12535f8 | Bug #55063: removed dependency and use of python-six
Comment 3 Florian Best univentionstaff 2022-08-29 17:47:12 CEST
OK: removal of python-six code
OK: YAML advisory
OK: Jenkins-Tests