Bug 55119 - import_computer script cannot import Ubuntu computers in UCS@school 5.0
import_computer script cannot import Ubuntu computers in UCS@school 5.0
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Import scripts
UCS@school 5.0
Other Linux
: P5 normal (vote)
: UCS@school 5.0 v3-errata
Assigned To: Tobias Wenzel
Johannes Königer
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2022-08-22 09:08 CEST by Daniel Tröder
Modified: 2022-11-17 16:25 CET (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.091
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2022102521000587
Bug group (optional): bitesize, Regression
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2022-08-22 09:08:22 CEST
The "import_computer" script was upgraded to instead of using UDM directly to use the UCS@school library.
That however does not have support for the "computers/ubuntu" UDM object type and thus the "import_computer" script does not support it anymore.
As this was supported before and not noted in the release notes, IMHO it's a regression.
A customer noted this: https://help.univention.com/t/rechnerobjekt-per-cli-import/20342

Add a "UbuntuComputer" class to ucs-school-lib/modules/ucsschool/lib/models/computer.py and that to the "computer_to_class_mapping" in the "import_computer" script.
Comment 2 Daniel Tröder univentionstaff 2022-08-22 12:02:59 CEST
Turns out the script did officially never support Ubuntu computers, only "ipmanagedclient, macos, windows": https://docs.software-univention.de/ucsschool-handbuch-4.4.html#school:schoolcreate:computers:import
Still it would be good to be able to import a non-proprietary OS.
Comment 4 Dirk Ahrnke univentionstaff 2022-11-10 11:57:34 CET
during further communication with customers it was also requested to import "computers/linux"
as far as I know the "ubuntu" flavour is used once a system is joined using the domain-join-assistant there appears to be no functional difference (see also bug 34641). So it shouldnt make a difference in the "linux" flavour can be used for import too.

Once this is implemented the documentation should make clear that the ability to import doesnt mean that the full featureset of Windows-Clients in UCS@School is available. This has to include "macos" too at least until there is a decision to document and support them in the same way as Windows-PC.
Comment 6 Tobias Wenzel univentionstaff 2022-11-15 15:43:52 CET
Package: ucs-school-import
Version: 18.0.26A~5.0.0.202211151540
Branch: ucs_5.0-0
Scope: ucs-school-5.0

Package: ucs-test-ucsschool
Version: 7.3.83
User: twenzel
Scope: ucs-school-5.0

Package: ucs-school-lib
Version: 13.0.30
User: twenzel
Scope: ucs-school-5.0

this also fixes https://forge.univention.org/bugzilla/show_bug.cgi?id=55386
but creates an inconsistency https://forge.univention.org/bugzilla/show_bug.cgi?id=55427
Comment 8 Tobias Wenzel univentionstaff 2022-11-17 13:18:29 CET
Test was fixed with ucs-test-ucsschool Version: 7.3.84A~5.0.0.202211170855
Comment 9 Johannes Königer univentionstaff 2022-11-17 13:30:31 CET
ucs-test-ucsschool 7.3.84A~5.0.0.202211170855 fixes the failing tests (83_python_hooks.py) seen in the Jenkins pipeline.
Comment 10 Tobias Wenzel univentionstaff 2022-11-17 16:25:52 CET
Errata updates for UCS@school 5.0 v3 have been released.

https://docs.software-univention.de/ucsschool-changelog/5.0v3/de/changelog.html

If this error occurs again, please clone this bug.