Bug 55156 - Choose your language step is broken
Choose your language step is broken
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UCS Installer
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-2-errata
Assigned To: Florian Best
Philipp Hahn
https://git.knut.univention.de/univen...
: python3-migration
Depends on: 51318
Blocks:
  Show dependency treegraph
 
Reported: 2022-09-01 09:55 CEST by Jürn Brodersen
Modified: 2022-09-21 17:07 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 6: Setup Problem: Issue for the setup process
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.137
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Regression
Max CVSS v3 score:


Attachments
Screenshot to show which step is broken (39.98 KB, image/png)
2022-09-01 09:55 CEST, Jürn Brodersen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jürn Brodersen univentionstaff 2022-09-01 09:55:17 CEST
Created attachment 10981 [details]
Screenshot to show which step is broken

Choose your language step is broken

The find_city call is broken which prevents a user to press enter to skip to the next step. You can still use the mouse to click next, but the next screen has default values. They can still be changed and you can continue the setup.

I think this screen is only shown in the appliance setup, so most users should have access to a mouse.

Interner Server-Fehler in "setup/find_city (wizard)".
Request: setup/find_city (wizard)

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/univention/management/console/base.py", line 344, in __error_handling
    six.reraise(etype, exc, etraceback)
  File "/usr/lib/python3/dist-packages/six.py", line 693, in reraise
    raise value
  File "/usr/lib/python3/dist-packages/univention/management/console/base.py", line 247, in execute
    function.__func__(self, request, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/decorators.py", line 181, in _response
    return function(self, request)
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/decorators.py", line 321, in _response
    result = _multi_response(self, request)
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/decorators.py", line 181, in _response
    return function(self, request)
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/decorators.py", line 443, in _response
    return list(function(self, iterator, *nones))
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/decorators.py", line 289, in _fake_func
    yield function(self, *args)
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/setup/__init__.py", line 704, in find_city
    pattern = pattern.decode(self.locale.codeset).lower()
AttributeError: 'str' object has no attribute 'decode'
Comment 1 Jürn Brodersen univentionstaff 2022-09-01 09:57:08 CEST
The version is important here:

Use a 5.0-2 appliance to reproduce. Both our internal and external appliance images are affected.
Comment 2 Florian Best univentionstaff 2022-09-01 11:04:42 CEST
Reproducer:
curl -i  http://Administrator:univention@10.200.27.47/univention/command/setup/find_city  -X POST -H 'Content-Type: application/json' -d '{"options":{"pattern":"Bremen"}}'
Comment 3 Florian Best univentionstaff 2022-09-01 13:34:08 CEST
This was a leftover from the Python 3 migration, where the request input data are regular strings and were previously decoded to unicode strings which is obsolete with Python 3 as they are already strings.

univention-system-setup.yaml
4d836970a0ea | Bug #55156: fix country search during system setup

univention-system-setup (13.0.3-37)
4d836970a0ea | Bug #55156: fix country search during system setup
Comment 4 Philipp Hahn univentionstaff 2022-09-21 16:28:05 CEST
Package: univention-system-setup
Version: 13.0.3-37A~5.0.0.202209011331
Branch: ucs_5.0-0
Scope: errata5.0-2

OK: 4d836970a0ea
FIXED: YAML 7ae362aebe8185cb875df6d49a9ba93a54fad9d7
OK: announce_errata

OK: curl -i  http://root:univention@10.200.17.222/univention/command/setup/find_city  -X POST -H 'Content-Type: application/json' -d '{"options":{"pattern":"Bremen"}}'
OK: tail /var/log/univention/management-console-web-server.log

FYI: Will only get used when next ISO and KVM templates are built.