Bug 55279 – Wrong Python type annotation for default, obsolete code

Bug 55279 - Wrong Python type annotation for default, obsolete code


Summary:	Wrong Python type annotation for default, obsolete code

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UDM (Generic)
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-2-errata
Assigned To:	Philipp Hahn
QA Contact:	Florian Best

URL:	https://git.knut.univention.de/univen...
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2022-10-17 18:15 CEST by Philipp Hahn
Modified:	2022-11-16 18:04 CET (History)
CC List:	0 users

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Flags:	hahn: Patch_Available+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Philipp Hahn

2022-10-17 18:15:34 CEST

Comment 1 Philipp Hahn

2022-10-18 10:45:38 CEST

[5.0-2] 2e0dc03f2a YAML Bug #55279
 doc/errata/staging/univention-directory-manager-modules.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[5.0-2] 4a5149f6fb fix[UDM]: Remove unused code
 doc/errata/staging/univention-directory-manager-modules.yaml    |  4 ++-
 .../univention-directory-manager-modules/debian/changelog       |  6 +++++
 .../modules/univention/admin/modules.py                         | 39 -----------------------------
 3 files changed, 9 insertions(+), 40 deletions(-)

[5.0-2] a7e759b953 refactor[UDM]: Use isinstance()
 .../univention-directory-manager-modules/modules/univention/admin/handlers/__init__.py      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[5.0-2] c5f4c32634 doc[UDM]: PEP-484 type annotations
 management/univention-directory-manager-modules/modules/univention/admin/__init__.py      | 4 ++--
 .../univention-directory-manager-modules/modules/univention/admin/handlers/users/user.py  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Package: univention-directory-manager-modules
Version: 15.0.13-12A~5.0.0.202210171856
Branch: ucs_5.0-0
Scope: errata5.0-2

Comment 2 Florian Best

2022-11-09 17:49:14 CET

OK: all commits valid.

univention-directory-manager-modules (15.0.13-12)
8d063937281c | refactor[UDM]: copy template default value explicitly
85063595b3cd | chore[UDM]: remove obsolete upgrade code
02d7ae46fbc1 | doc[UDM]: PEP-484 type annotations
f0249fc2b4a1 | refactor[UDM]: flatten default value assignment
6f5e492fe50c | refactor[UDM]: Reorder code
1e2d6fb96919 | refactor[UDM]: Use template_object.items()
9d65354710a2 | refactor[UDM]: Convert multiple != to not in
437c1a0765e3 | fix[UDM]: Remove unused code
a5f6201f8986 | Revert "fix[UDM]: Remove unused code"
4a5149f6fb51 | fix[UDM]: Remove unused code
a7e759b953a5 | refactor[UDM]: Use isinstance()
c5f4c32634d3 | doc[UDM]: PEP-484 type annotations

Comment 3 Philipp Hahn

2022-11-16 18:04:00 CET

<https://errata.software-univention.de/#/?erratum=5.0x489>