Bug 55517 – make "unset" vs "empty string" distinguishable from each other in UMC UCR module

Bug 55517 - make "unset" vs "empty string" distinguishable from each other in UMC UCR module


Summary:	make "unset" vs "empty string" distinguishable from each other in UMC UCR module

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - Univention Configuration Registry
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-4-errata
Assigned To:	Mika Westphal
QA Contact:	Christian Castens

URL:	https://git.knut.univention.de/univen...
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2022-12-22 15:22 CET by Stefan Gohmann
Modified:	2023-07-12 13:57 CEST (History)
CC List:	5 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?:	5: Will affect all installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.229
Enterprise Customer affected?:	Yes
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2022122121000269, 2023051521000363, 2023053021000272, 2023053121000191, 2023061921000247
Bug group (optional):	bitesize
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stefan Gohmann

2022-12-22 15:22:39 CET

One tried to remove the value for the UCR variable mail/postifix/mynetworks via UMC UCR. The descriptions says:

> If the variable is unset, '127.0.0.0/8' applies.

So, he removed the value. Unfortunately, the UCR variable was set to an empty string which leads to a broken self service.

Maybe a popup could be shown which asks if the UCR variable should be set to an empty value or removed.

Comment 1 Ingo Steuwer

2023-05-02 13:53:57 CEST

Proposal for an UMC implementation:

- the UI to change the value of an UCR variable offers an "unset" button next to the "save" button
- in case the user tries to save an "empty string", a popup asks if really an empty string should be set, or if the variable should be "unset"
- if possible both the edit dialogue and the popup offer an explanation for the difference between the two, maybe enhanced with a link to an help article

Beside that we should review the coding guidelines to check if we can consider a rule that UCR templates need to be written in a way that empty values do not lead to an misconfigured service.

Comment 3 Christina Scheinig

2023-06-12 15:12:41 CEST

Happened again, this also causes the systemdiagnoses to give warnings about those variables. e.g. squid/httpport

This will affect all domains, when the UMC ucr is used to manage the ucr variables!

Comment 4 Christina Scheinig

2023-06-13 13:24:04 CEST

Seen in the next Ticket: 2023053021000272

Einige UCR-Variablen haben momentan ungültige Werte.
Dieser Test wurde erst kürzlich hinzugefügt; einige Warnungen können unproblematisch sein.
Bitte untersuchen Sie diese wenn Sie auf diesem System Probleme beobachten.
Benutzen Sie das Modul Modul "Univention Configuration Registry", um diese Werte zu korrigieren.
Die Variable 'squid/parent/port' hat den ungültigen Wert ''.

Comment 5 Christina Scheinig

2023-06-14 10:59:48 CEST

Next Customer:
2023053121000191

Comment 6 Christina Scheinig

2023-06-19 13:18:29 CEST

Again next customer. Squid is broken and not usable anymore!

Comment 8 Mika Westphal

2023-07-06 11:21:28 CEST

If a UCR variable is changed to an empty value via UMC, a confirmation dialog is displayed to let the user decide on whether to store an empty string or to actually delete the variable.

univention-management-console-module-ucr.yaml
4a728fd3845d | Bug #55517: showing confirmation dialog before saving an empty value into an UCR variable

univention-management-console-module-ucr (9.0.1-2)
4a728fd3845d | Bug #55517: showing confirmation dialog before saving an empty value into an UCR variable

ucs-test (10.0.15-10)
4a728fd3845d | Bug #55517: showing confirmation dialog before saving an empty value into an UCR variable

Comment 9 Christian Castens

2023-07-06 11:28:19 CEST

QA:
   - confirmation dialog:  OK
   - texts and translations:  OK
   - advisories:  OK
   - no related errors/tracebacks in logfiles:  OK

Comment 10 Christian Castens

2023-07-12 13:57:18 CEST

<https://errata.software-univention.de/#/?erratum=5.0x732>