Bug 55558 - Unhandeled dependency of UCRV ldap/translog-ignore-temporary from ldap/translogfile
Unhandeled dependency of UCRV ldap/translog-ignore-temporary from ldap/transl...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: LDAP
UCS 5.0
Other Linux
: P5 minor (vote)
: UCS 5.0-2-errata
Assigned To: Philipp Hahn
Peter Stoll
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-11 16:01 CET by Lukas Zumvorde
Modified: 2023-02-01 17:24 CET (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 7: Crash: Bug causes crash or data loss
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.160
Enterprise Customer affected?: Yes
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): bitesize, Workaround is available
Max CVSS v3 score:
hahn: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lukas Zumvorde univentionstaff 2023-01-11 16:01:22 CET
If the UCRV ldap/translogfile is unset and ldap/translog-ignore-temporary is set to "true" then the slapd.conf will be invalid and prevent slapd from starting. To fix this we need to make ldap/translog-ignore-temporary only effectively making a change to slapd.conf if ldap/translogfile is set.


Setting the UCRV ldap/translog-ignore-temporary to "true" creates the line 

  translog-ignore-temporary    true

in the slapd.conf. However this depends on the translog overlay module being activated as well. This only happens if ldap/translogfile is being set. The following patch should be enough to fix the issue.


modified   management/univention-ldap/conffiles/etc/ldap/slapd.conf.d/40univention-ldap-server_database
@@ -8,8 +8,8 @@ print('')
 if configRegistry.get('ldap/translogfile'):
 	print("overlay\t\ttranslog")
 	print("translog\t%s" % configRegistry['ldap/translogfile'])
-if configRegistry.is_true('ldap/translog-ignore-temporary'):
-	print("translog-ignore-temporary\ttrue")
+	if configRegistry.is_true('ldap/translog-ignore-temporary'):
+		print("translog-ignore-temporary\ttrue")
 if configRegistry.is_true('ldap/k5pwd', True):
 	print("overlay\t\tk5pwd")
 if configRegistry.is_true('ldap/pwd_scheme_kinit', True):
Comment 1 Philipp Hahn univentionstaff 2023-01-20 17:48:02 CET
Package: univention-ldap
Version: 16.0.7-26A~5.0.0.202301201745
Branch: ucs_5.0-0
Scope: errata5.0-2

[5.0-2] 1087b64d44 Bug #34877: univention-ldap 16.0.7-26A~5.0.0.202301201745
 doc/errata/staging/univention-ldap.yaml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
Comment 2 Peter Stoll univentionstaff 2023-01-23 11:20:29 CET
QA:
- Code review
- installed univention-ldap package
- diff-ed /etc/ldap/slapd.conf before and after
- tested size limit exceeded behaviour before and after.
Comment 3 Peter Stoll univentionstaff 2023-01-23 11:27:07 CET
QA:
- Check YAML file for completeness and validity