Univention Bugzilla – Bug 55667
Wrong Link to Release Notes in Upgrade Notification for 5.0-3
Last modified: 2023-03-01 14:55:24 CET
In the popup notification window for UCS 5.0-3 in UMC there is a wrong link to the Release Notes: https://docs.software-univention.de/release-notes-5.0-3-de.html This results in a 404 error. The correct link is: https://docs.software-univention.de/release-notes/5.0-3/de/ (or -en vs /en/ respectively) I think a RedirectMatch or similar in webserver config should fix this issue for now, but in the long run the UMC dialog should contain the correct link.
Already fixed. [5.0-3] 74429c61fe fix(up): Release note links base/univention-updater/script/preup.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) [5.0-3] 65616abb14 fix(up): Release note links base/univention-updater/script/preup.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) https://updates.software-univention.de/dists/ucs503/preup.sh
Reopen: This bug is about the info in the UMC, so a fix in the product would have to be an errata update for 5.0-2. https://git.knut.univention.de/univention/ucs/-/blob/5.0-3/base/univention-updater/umc/js/updater.js#L340 A redirect in the docs webpage should be considered.
Created attachment 11035 [details] Patch for updater.js The patch updates the pattern for the URL in the JavaScript code and suggests the change to the German translation. Please don't apply the part for de.po exactly without prior update of the message IDs in the PO file.
The redirect web pages exist, but are not yet published, because the release pipeline fails because of some other error. I revert the breaking change so that the redirects are published.
The redirect pages are now online: * https://docs.software-univention.de/release-notes-5.0-3-en.html * https://docs.software-univention.de/release-notes-5.0-3-de.html
I added the proposed patch and create a merge request. But I have no idea how to update the translation properly, build the package and do the needed testing. I give the bug back to you, Philipp.
Merged and built: [5.0-3] e542d39604 Bug #55667: univention-updater 15.0.6-4 base/univention-updater/debian/changelog | 6 ++++++ doc/errata/staging/univention-updater.yaml | 10 ++++++++++ 2 files changed, 16 insertions(+) [5.0-3] bc01bfb354 fix(up): Update link schema to release notes in update base/univention-updater/umc/js/de.po | 6 +++--- base/univention-updater/umc/js/updater.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) Package: univention-updater Version: 15.0.6-4A~5.0.0.202302231438 Branch: ucs_5.0-0 Scope: errata5.0-3 [5.0-3] 8ea4b4a993 Bug #55667: univention-updater 15.0.6-4A~5.0.0.202302231438 doc/errata/staging/univention-updater.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Let's hope our prediction of the future is better now.
OK: Tested with 5.0-2 - link is correct now. I adjusted the YAML so that it will be released for 5.0-2, too.
(In reply to Dirk Wiesenthal from comment #8) > OK: Tested with 5.0-2 - link is correct now. I adjusted the YAML so that it > will be released for 5.0-2, too. NO: The updater in 5.0-3 is different from 5.0-2: it contains all the tap2spaces changes and more. It MUST not be released for 5.0-2!
The change here will only affect FUTURE versions of UCS. To fix the link for UCS 5.0-3 we would need to change the version of UCS 5.0-2. The Updater has always been the tricky bit as you must predict, how a future UCS version will be layed out. And changing the layout of the documentation page did break it.
UMC German, English: OK Code review: OK (CLI: OK) YAML: OK
<https://errata.software-univention.de/#/?erratum=5.0x601>