Bug 55685 – UCR Type for mail/antispam/requiredhits "int" is wrong, needs to allow real numbers

Bug 55685 - UCR Type for mail/antispam/requiredhits "int" is wrong, needs to allow real numbers


Summary:	UCR Type for mail/antispam/requiredhits "int" is wrong, needs to allow real n...

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Mail
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-4-errata
Assigned To:	Mika Westphal
QA Contact:	Florian Best

URL:	https://git.knut.univention.de/univen...
Keywords:

Depends on:	55554
Blocks:
	Show dependency tree / graph

Reported:	2023-02-16 08:41 CET by Ingo Steuwer
Modified:	2023-07-12 13:57 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	1: Nuisance – not a big deal but noticeable
User Pain:	0.046
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	bitesize, Regression
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ingo Steuwer

2023-02-16 08:41:54 CET

The Type "int" for the spamassassin setting "required_score" is wrong. Spamassissin allows real numbers here.


UCS 5.0-3:

#ucr info mail/antispam/requiredhits
mail/antispam/requiredhits: 5
 SpamAssassin operates a point system, [..]
 Categories: service-mail
 Default: (not set)
 Type: int


From the documentation of spamassissin:

https://spamassassin.apache.org/full/3.1.x/doc/Mail_SpamAssassin_Conf.html

required_score n.nn (default: 5)
Set the score required before a mail is considered spam. n.nn can be an integer or a real number. [..]

Comment 1 Mika Westphal

2023-07-07 07:23:43 CEST

The UCR variable `mail/antispam/requiredhits` was using an integer but the value can be a float or a real number. This is now possible.

univention-spamassassin.yaml
a99341b3f8ae | Bug #55685: Changed the UCR type of mail/antispam/requiredhits to string

univention-spamassassin (11.0.1-3)
a99341b3f8ae | Bug #55685: Changed the UCR type of mail/antispam/requiredhits to string

Comment 2 Florian Best

2023-07-12 13:16:35 CEST

OK: # ucr set mail/antispam/requiredhits=a
Setting mail/antispam/requiredhits
E: Value 'a' incompatible for 'mail/antispam/requiredhits'
OK: # ucr set mail/antispam/requiredhits=5.0
Setting mail/antispam/requiredhits
File: /etc/spamassassin/90_univention.cf
OK: # ucr set mail/antispam/requiredhits=5..0000000000
Setting mail/antispam/requiredhits
E: Value '5..0000000000' incompatible for 'mail/antispam/requiredhits'
OK: # ucr set mail/antispam/requiredhits=5.0000000000
Setting mail/antispam/requiredhits
File: /etc/spamassassin/90_univention.cf
OK: # ucr set mail/antispam/requiredhits=5
Setting mail/antispam/requiredhits
File: /etc/spamassassin/90_univention.cf
OK: # ucr set mail/antispam/requiredhits=.5
Setting mail/antispam/requiredhits
E: Value '.5' incompatible for 'mail/antispam/requiredhits'

~ I think this is also allowed by the configuration but not via UCR. OK for now.

# ucr set mail/antispam/requiredhits=5.
Setting mail/antispam/requiredhits
E: Value '5.' incompatible for 'mail/antispam/requiredhits'

Adjusted the advisory wording:
bbcaa93ee3 chore(univention-spamassassin): update advisory

Comment 3 Christian Castens

2023-07-12 13:57:18 CEST

<https://errata.software-univention.de/#/?erratum=5.0x733>