Bug 55686 – Samba share access fails due to Python2/3 bytestring issue in samba4-idmap.py

Bug 55686 - Samba share access fails due to Python2/3 bytestring issue in samba4-idmap.py


Summary:	Samba share access fails due to Python2/3 bytestring issue in samba4-idmap.py

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Samba4
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-3-errata
Assigned To:	Arvid Requate
QA Contact:	Julia Bremer

URL:	https://git.knut.univention.de/univen...
Keywords:	python3-migration

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2023-02-16 13:08 CET by Arvid Requate
Modified:	2023-02-22 13:03 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	1: Will affect a very few installed domains
How will those affected feel about the bug?:	5: Blocking further progress on the daily work
User Pain:	0.143
Enterprise Customer affected?:	Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2023020621000484
Bug group (optional):
Max CVSS v3 score:

Flags:	requate: Patch_Available+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvid Requate

2023-02-16 13:08:14 CET

root@system:~# smbclient //$(hostname -f)/affecteduser -U affecteduser
session setup failed: NT_STATUS_INVALID_SID

Cause:

ldbsearch -H /var/lib/samba/private/idmap.ldb "xidNumber=b*" objectSid xidnumber

shows bytestring representations of the integer Posix-IDs:

xidNumber: b'2894'

root@system:~# univention-app info
UCS: 5.0-2 errata460
Installed: cups=2.2.1 dhcp-server=12.0 samba4=4.16
Upgradable: 

Comparing the backups of idmap.ldb in /var/univention-backup I see that this is not a one-off Python-3-migration issue during the Update to UCS 5.0-0 but some ongoing problem.

Comment 1 Arvid Requate

2023-02-20 15:16:24 CET

29b65955f3 | Fix xidNumber decoding in samba4-idmap.py
23c6e041cc | Advisory

Package: univention-samba4
Version: 9.0.11-6A~5.0.0.202302201422
Branch: ucs_5.0-0
Scope: errata5.0-3

Comment 2 Julia Bremer

2023-02-22 09:48:38 CET

OK: Fixes broken entries on upgrade
OK: Doesn't create more broken entries 
OK: Code review
OK: YAML

Verified

Comment 3 Philipp Hahn

2023-02-22 13:03:41 CET

<https://errata.software-univention.de/#/?erratum=5.0x584>