Bug 56332 - 26univention-samba.inst calls smbpasswd with machine/ldap secret visible in process list
26univention-samba.inst calls smbpasswd with machine/ldap secret visible in p...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Samba
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-5-errata
Assigned To: Florian Best
Arvid Requate
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-17 18:20 CEST by Florian Best
Modified: 2023-11-06 15:19 CET (History)
0 users

See Also:
What kind of report is it?: Security Issue
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Security
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2023-07-17 18:20:32 CEST
26univention-samba.inst calls smbpasswd with machine/ldap secret visible in process list:

services/univention-samba/26univention-samba.inst:      smbpasswd -w "$(< /etc/machine.secret)"
services/univention-samba/26univention-samba.inst:      smbpasswd -w "$(< /etc/ldap.secret)"

smbpasswd doesn't provide a "-y" password file option.
Comment 1 Florian Best univentionstaff 2023-10-23 15:29:33 CEST
(In reply to Florian Best from comment #0)
> smbpasswd doesn't provide a "-y" password file option.

Instead "-W" can be used.
MR: https://git.knut.univention.de/univention/ucs/-/merge_requests/847
Comment 2 Florian Best univentionstaff 2023-10-25 16:44:45 CEST
smbpasswd -W is not used.

univention-samba.yaml
49e9b678a30c | fix(samba): do not leak password in process list

univention-samba (14.0.9-2)
49e9b678a30c | fix(samba): do not leak password in process list
Comment 3 Arvid Requate univentionstaff 2023-10-26 14:35:06 CEST
Verified:
* Code review
* Package update
* Advisory