Bug 56343 - deprecation warning logged as error (using univention.uldap.access instance is deprecated. Use univention.admin.uldap.access instead.)
deprecation warning logged as error (using univention.uldap.access instance i...
Status: NEW
Product: UCS
Classification: Unclassified
Component: UDM (Generic)
UCS 5.0
Other Linux
: P5 normal (vote)
: ---
Assigned To: UMC maintainers
UMC maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-20 16:02 CEST by Daniel Tröder
Modified: 2023-08-08 09:28 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 5: Will affect all installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.286
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2023-07-20 16:02:03 CEST
The message
---
using univention.uldap.access instance is deprecated. Use univention.admin.uldap.access instead.
---
is logged at ERROR level. This makes a lot of logfiles completely unreadable!

wc -l /var/log/univention/management-console-module-diagnostic.log
69979
grep -c "using univention.uldap.access instance" management-console-module-diagnostic.log
61212

Lower the log level of that message to something lower than the default loglevel.
Comment 1 Florian Best univentionstaff 2023-07-21 09:33:32 CEST
Why not instead fix the cause that the wrong instance is given to UDM?!
Comment 2 Florian Best univentionstaff 2023-07-21 09:51:07 CEST
This should be the patch for it:

diff --git ucs-school-umc-diagnostic/umc/python/diagnostic/plugins/912_ucsschool_invalid_group_names.py ucs-school-umc-diagnostic/umc/python/diagnostic/plugins/912_ucsschool_invalid_group_names.py
index bf0959792..e8b4edb69 100755
--- ucs-school-umc-diagnostic/umc/python/diagnostic/plugins/912_ucsschool_invalid_group_names.py
+++ ucs-school-umc-diagnostic/umc/python/diagnostic/plugins/912_ucsschool_invalid_group_names.py
@@ -40,7 +40,7 @@ from ucsschool.lib.models.share import ClassShare, WorkGroupShare
 from ucsschool.lib.schoolldap import SchoolSearchBase
 from univention.lib.i18n import Translation
 from univention.management.console.modules.diagnostic import Warning
-from univention.uldap import getAdminConnection
+from univention.admin.uldap import getAdminConnection
 
 re_name_with_multiple_whitespaces = re.compile(r"\s{2,}")
 

All other diagnostic scripts seem to be ok.
Comment 3 Daniel Tröder univentionstaff 2023-08-08 09:28:36 CEST
I cloned the bug to fix the import → bug #56413.

The log level of the deprecation warning is too high nonetheless.