Bug 56458 - Extend theme: border-radius and color for buttons and login specific variables
Extend theme: border-radius and color for buttons and login specific variables
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-4-errata
Assigned To: Dirk Wiesenthal
Julia Bremer
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-20 15:49 CEST by Dirk Wiesenthal
Modified: 2023-08-23 14:54 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2023-08-20 15:49:41 CEST
In order to easily adjust the appearance of our web pages via a theme, we need more variables. This was recognized when trying to customize the Keycloak login page.

We would need:

--border-radius-container
--border-radius-interactable
(currently they exist in UMC only, we need them "globally")

--button-text-color
Currently, it is --font-color-contrast-high by inheritance. But this proves to be a problem if your background color is white-ish (=> contrast is dark), but your primary color is deep blue (=> contrast would be light). You cannot easily theme the page so that you can read text on containers AND buttons.

--login-background
--login-logo
These two are not very global, they would only be used in Keycloak. But we should mention them here because otherwise we don't know where to "document" them. Keycloak does not have a real custom.css. This has already been done for the serveroverview.
Disadvantage would be that without knowledge, one would assume that they apply to SimpleSAMLphp, too. I expect little new themes to be created for SimpleSAMLphp with the replacement by Keycloak on the horizon. So I think it is okay; we don't aggressively advertise these new variables anyway. We just have them for reference in the code.
Comment 2 Dirk Wiesenthal univentionstaff 2023-08-21 15:55:35 CEST
Also added --login-box-background
I had to make sure that with this update and new variables, old themes still work, although they are based off of (copied from) themes that did not have these variables.

univention-web.yaml
3eebfe93fa10 | Bug #56458: Extend theme with border-radius and color for buttons as well as login specific variables

univention-web (4.0.4-3)
3eebfe93fa10 | Bug #56458: Extend theme with border-radius and color for buttons as well as login specific variables
Comment 3 Julia Bremer univentionstaff 2023-08-22 21:34:34 CEST
OK: new variables
OK: YAML
OK: Theme works with old themes (checked mv theme)
OK: Keycloak themes
Verified