Bug 56510 - Max request body size of UMC module process is not configurable
Max request body size of UMC module process is not configurable
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-5-errata
Assigned To: Florian Best
Marius Meschter
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-31 13:23 CEST by Florian Best
Modified: 2023-09-27 18:17 CEST (History)
0 users

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2023-08-31 13:23:42 CEST
The max request body size of HTTP requests in the UMC modules is currently not configurable so that the tornado default is used.
For the UMC-Server this is already configurable.

As file uploads are now transferred directly to the UMC modules instead of a JSON object this must be configurable now.

We can use the same code which we use for the UMC server.
Comment 1 Florian Best univentionstaff 2023-09-19 16:11:13 CEST
univention-management-console.yaml
7ae9587100c7 | fix(umc): fix configurability of maximum request body size

univention-management-console (12.0.31-15)
7ae9587100c7 | fix(umc): fix configurability of maximum request body size
    The maximum request body size was configured in the UMC-Server but not
    in the UMC module process and therefore lead to 400 bad requests.
    Since the UMC rewrite file uploads aren't handeld anymore in the
    UMC-Server core and given as short JSON information with a
    dumped-filename to the module process but directly forwarded to the
    module process this became an error.
Comment 2 Marius Meschter univentionstaff 2023-09-22 09:36:53 CEST
QA:
- code review: OK
- package upgrade: OK
- YAML: OK
- trying to upload a license file with size 120MiB where umc/http/max_request_body_size=136314880 fails before upgrade with 400
- trying to upload a license file with size 120MiB where umc/http/max_request_body_size=136314880 succeeds after upgrade with 200