Bug 56559 - Remove keycloak specific settings from themes
Summary: Remove keycloak specific settings from themes
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
Version: UCS 5.0
Hardware: Other Linux
: P5 normal
Target Milestone: UCS 5.0-4-errata
Assignee: Felix Botner
QA Contact: Arvid Requate
URL: https://git.knut.univention.de/univen...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-08 13:34 CEST by Felix Botner
Modified: 2023-09-27 18:06 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID:
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Botner univentionstaff 2023-09-08 13:34:31 CEST 
We don't need this in the theme styles, it will be defined in the keycloak app.

	// login page - keycloak only!
	--login-background: var(--default-background-color)
	--login-logo: url("../img/login_logo.svg") no-repeat center
	--login-box-background: var(--bgc-content-container)
Comment 1 Felix Botner univentionstaff 2023-09-13 13:13:36 CEST 
Successful build
Package: univention-web
Version: 4.0.4-5
Branch: ucs_5.0-0
Scope: errata5.0-4


-> univention-web.yaml
Comment 2 Philipp Hahn univentionstaff 2023-09-13 18:24:14 CEST 
As 5.0-5 had been released yesterday 5.0-4 should only get security updates.

Please
- change TM to UCS 5.0-5-errata
- cherry pick source package to errata5.0-5
- copy over build package:
  cd /var/univention/buildsystem2/apt/ucs_5.0-0-errata5.0-5
  repo-copy-dsc -vca amd64 ../ucs_5.0-0-errata5.0-4/source/univention-web_4.0.4-5.dsc
- remove from errata5.0-4
- remove doc/errata/staging/univention-web.yaml from git branch 5.0-4
- add doc/errata/staging/univention-web.yaml to git branch 5.0-5
- update doc/errata/staging/univention-web.yaml
  version: [5]
  scope: ucs_5.0-0-errata5.0-5
Comment 3 Felix Botner univentionstaff 2023-09-14 10:28:29 CEST 
(In reply to Philipp Hahn from comment #2)
> As 5.0-5 had been released yesterday 5.0-4 should only get security updates.
> 
> Please
> - change TM to UCS 5.0-5-errata
> - cherry pick source package to errata5.0-5
> - copy over build package:
>   cd /var/univention/buildsystem2/apt/ucs_5.0-0-errata5.0-5
>   repo-copy-dsc -vca amd64
> ../ucs_5.0-0-errata5.0-4/source/univention-web_4.0.4-5.dsc
> - remove from errata5.0-4
> - remove doc/errata/staging/univention-web.yaml from git branch 5.0-4
> - add doc/errata/staging/univention-web.yaml to git branch 5.0-5
> - update doc/errata/staging/univention-web.yaml
>   version: [5]
>   scope: ucs_5.0-0-errata5.0-5

as discussed, we want to test a new process for sec updates for "univention" packages
 * cherry-pick into old version
 * build for old version
 * yaml file and release in old version
to 
 * be sure only the sec update changes are backported
 * be able to test old version before the release

There is no technical objection here but we have to
 * write down the process
 * inform the release team to check git branches for all maintained UCS
   version (so 5.0-4 too) for yaml files

OK?
Comment 4 Arvid Requate univentionstaff 2023-09-16 14:22:11 CEST 
Verified:
* Package versioning
* Package update
* Advisory