Bug 56590 – Adapt code to uldap3, to prevent misleading error message

Bug 56590 - Adapt code to uldap3, to prevent misleading error message


Summary:	Adapt code to uldap3, to prevent misleading error message

Status:	ASSIGNED

Product:	UCS@school
Classification:	Unclassified
Component:	HTTP-API (Kelvin)
Version:	unspecified
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	Alexander Steffen
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2023-09-14 16:13 CEST by Finn David
Modified:	2024-04-25 07:06 CEST (History)
CC List:	4 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?:	3: Will affect average number of installed domains
How will those affected feel about the bug?:	1: Nuisance – not a big deal but noticeable
User Pain:	0.017
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2023091221000601, 2023110621000431
Bug group (optional):
Max CVSS v3 score:

Flags:	troeder: Patch_Available+

Attachments
fix deprecated return value check (1.43 KB, patch) 2023-09-15 07:53 CEST, Daniel Tröder	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Finn David

2023-09-14 16:13:17 CEST

During a troubleshooting on a customer system regarding synchronisation problems between the central IDM and the LDAPSync for the school cloud, the following error message was discovered in the log for the Kelvin API:

http.log:2023-09-12 14:45:42 ERROR [228][6b5573aa6f] Error modifying password hashes of 'uid=

Although the operation was successful, this error appears in the log, probably since we switched to the library uldap3.

Comment 1 Daniel Tröder

2023-09-15 07:52:12 CEST

uldap3 returns None on success and raises (ModifyError, NoObject) on error.
The return value cannot be used to determine success/error.

Comment 2 Daniel Tröder

2023-09-15 07:53:57 CEST

Created attachment 11126 [details]
fix deprecated return value check

_Untested_ fix for the wrong error / missing success message.