Univention Bugzilla – Bug 56624
System diagnostics "Success" text does not disappear after re-running with non passing checks
Last modified: 2023-10-11 16:36:31 CEST
Created attachment 11127 [details] example of bug If a full check in the systems diagnostics module is run all the checks pass a text with "Success: No problems could be detected pops up". When then clicking the "run system diagnostics" button and a check doesn't pass it's failure text is displayed. However the success text does not disappear and will continued to be displayed.
MR: https://git.knut.univention.de/univention/ucs/-/merge_requests/900#dd246564400c6eed9c22131b9df84b594d4d6579
How to reproduce: - Open system diagnostics module - Make sure all checks pass so "Success: No problems could be detected" is visible - Make a check fail (e.g. systemctl stop univention-directory-notifier.service) - Click "Run system diagnosis" to re-run all checks - "Success: No problems could be detected" is still visible
umc diagnostic module: The plugin responsible for showing the "Success" text was never removed from the dojo store after having been inserted into it when a successful diagnostic check ran. It is now being removed from the store before a diagnostic run starts. 133_system_diagnostic.py test: The test was previously using get_by_text to detect if the check, which was supposed to fail, failed. This sometimes lead to the get_by_text resolving to two locators. It has now been changed to get_by_role("button") which will resolve correctly to one element. univention-management-console-module-diagnostic.yaml 25f6c2b5b944 | fix(diag): remove success plugin before diagnosis univention-management-console-module-diagnostic (6.0.6-3) 25f6c2b5b944 | fix(diag): remove success plugin before diagnosis ucs-test (10.0.19-11) 8f65c0e5677b | test(browser): detect by role instead of by_text
OK: no success message is shown after rerun with failing tests OK: YAML
<https://errata.software-univention.de/#/?erratum=5.0x834>