Bug 56647 – [5.0-4] Python2 incompatible template /etc/simplesamlphp/00authsources.php

Bug 56647 - [5.0-4] Python2 incompatible template /etc/simplesamlphp/00authsources.php


Summary:	[5.0-4] Python2 incompatible template /etc/simplesamlphp/00authsources.php

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	SAML
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-5-errata
Assigned To:	Nikola Radovanovic
QA Contact:	Julia Bremer

URL:	https://git.knut.univention.de/univen...
Keywords:

Depends on:	56074 56588
Blocks:
	Show dependency tree / graph

Reported:	2023-09-25 09:23 CEST by Dirk Wiesenthal
Modified:	2023-10-04 17:06 CEST (History)
CC List:	6 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	1: Will affect a very few installed domains
How will those affected feel about the bug?:	4: A User would return the product
User Pain:	0.069
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Regression
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dirk Wiesenthal

2023-09-25 09:23:48 CEST

We should backport to 5.0-4 as this is a regression introduced in 5.0-4

+++ This bug was initially created as a clone of Bug #56588 +++

Bug #56074 introduced a Python 2 incompatibility which broke a very important customers whole SAML config, as they were still setting UCR variables for SAML in a Python 2 process.

This patch will restore Python 2 compatibility:

diff --git saml/univention-saml/conffiles/etc/simplesamlphp/00authsources.php saml/univention-saml/conffiles/etc/simplesamlphp/00authsources.php
index dcec19737b..2c81ca07bd 100644
--- saml/univention-saml/conffiles/etc/simplesamlphp/00authsources.php
+++ saml/univention-saml/conffiles/etc/simplesamlphp/00authsources.php
@@ -79,7 +79,7 @@ print(
         php_string("uid=sys-idp-user,cn=users,%s" % base),
         php_string(password),
         php_string(base),
-    ),
+    )
 )
 @!@
     // LDAP authentication source.

+++ This bug was initially created as a clone of Bug #56074 +++

Comment 3 Julia Bremer

2023-10-04 15:46:32 CEST

OK: Python2 compatible
OK: Package built
OK: Yaml
OK: To be released for 5.0-5 and 5.0-4
OK update from 5.0-4 to 5.0-5 with the updated package

Verified

Comment 4 Iván.Delgado

2023-10-04 17:06:37 CEST

<https://errata.software-univention.de/#/?erratum=5.0x828>