Bug 56717 - remove unused icons without OSI compliant license
remove unused icons without OSI compliant license
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-6-errata
Assigned To: Iván.Delgado
Christian Castens
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2023-10-09 13:59 CEST by Ingo Steuwer
Modified: 2023-12-14 15:04 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
Screenshot showing UCS portal using the icon (26.58 KB, image/png)
2023-11-30 13:12 CET, Iván.Delgado
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ingo Steuwer univentionstaff 2023-10-09 13:59:16 CEST
The icon "licenseMail.svg" includes a limited usage license as it is derived from an Icon from "IconMonstr". The license may conflict with our business modell (it seems like re-distribution in a commercial product is not allowed without permission by the copyright holder). In addition, as it is no OSI compliant license, it hinders us to release our implementation on openCode.

In my understanding, the icon isn't used in UCS 5 anymore, so we should remove it (and maybe other unused icons, too). In case it is still in use we need to replace it.

Path in GIT: management/univention-management-console/www/management/widgets/licenseMail.svg
Comment 1 Florian Best univentionstaff 2023-10-10 09:28:03 CEST
It is used:
management/univention-management-console/www/management/style.css-.umc .umcAppDialogPage-licenseImport .umcPageIcon {
management/univention-management-console/www/management/style.css:      background-image: url(widgets/licenseMail.svg);
management/univention-management-console/www/management/style.css-}

We have the permission:
https://twitter.com/alexklaeser/status/350170663065092096

There are at least the following additional icons from iconmonstr.com:
management/univention-appcenter/umc/js/appcenter/carouselArrowRight.svg:You may NOT sub-license, resell, rent, redistribute or otherwise transfer the icon without express written permission from iconmonstr.com -->
management/univention-appcenter/umc/js/appcenter/maximize.svg:You may NOT sub-license, resell, rent, redistribute or otherwise transfer the icon without express written permission from iconmonstr.com -->
management/univention-appcenter/umc/js/appcenter/minimize.svg:You may NOT sub-license, resell, rent, redistribute or otherwise transfer the icon without express written permission from iconmonstr.com -->
management/univention-appcenter/umc/js/appcenter/statusIcons.svg:You may NOT sub-license, resell, rent, redistribute or otherwise transfer the icon without express written permission from iconmonstr.com -->
management/univention-appcenter/umc/js/appcenter/videoPlayButton.svg:   sodipodi:docname="iconmonstr-video-15.svg">
Comment 2 Ingo Steuwer univentionstaff 2023-10-10 10:46:50 CEST
(In reply to Florian Best from comment #1)
> It is used:
> management/univention-management-console/www/management/style.css-.umc
> .umcAppDialogPage-licenseImport .umcPageIcon {
> management/univention-management-console/www/management/style.css:     
> background-image: url(widgets/licenseMail.svg);
> management/univention-management-console/www/management/style.css-}

I noticed that it is mentioned in the code, but I couldn't identify the use case -- the icon of the license upload looks different. Is this code still in use?

> 
> We have the permission:
> https://twitter.com/alexklaeser/status/350170663065092096

I can't read the tweet stating under which conditions we can use the icons, I see only our answer to confirm to those conditions.


> 
> There are at least the following additional icons from iconmonstr.com:
> management/univention-appcenter/umc/js/appcenter/carouselArrowRight.svg:You
> may NOT sub-license, resell, rent, redistribute or otherwise transfer the
> icon without express written permission from iconmonstr.com -->
> management/univention-appcenter/umc/js/appcenter/maximize.svg:You may NOT
> sub-license, resell, rent, redistribute or otherwise transfer the icon
> without express written permission from iconmonstr.com -->
> management/univention-appcenter/umc/js/appcenter/minimize.svg:You may NOT
> sub-license, resell, rent, redistribute or otherwise transfer the icon
> without express written permission from iconmonstr.com -->
> management/univention-appcenter/umc/js/appcenter/statusIcons.svg:You may NOT
> sub-license, resell, rent, redistribute or otherwise transfer the icon
> without express written permission from iconmonstr.com -->
> management/univention-appcenter/umc/js/appcenter/videoPlayButton.svg:  
> sodipodi:docname="iconmonstr-video-15.svg">

Then we need to replace them too.

We can ask an external agency for new Icons if that's helpfull.
Comment 5 Iván.Delgado univentionstaff 2023-11-30 13:10:23 CET
(In reply to Ingo Steuwer from comment #2)
 
> I noticed that it is mentioned in the code, but I couldn't identify the use
> case -- the icon of the license upload looks different. Is this code still
> in use?

The icon is displayed after sending the license mail
Welcome! > Request a new license > enter the email address and send the license
Comment 6 Iván.Delgado univentionstaff 2023-11-30 13:12:10 CET
Created attachment 11154 [details]
Screenshot showing UCS portal using the icon
Comment 7 Ingo Steuwer univentionstaff 2023-11-30 13:22:11 CET
(In reply to Iván.Delgado from comment #6)
> Created attachment 11154 [details]
> Screenshot showing UCS portal using the icon

(In reply to Iván.Delgado from comment #5)
> (In reply to Ingo Steuwer from comment #2)
>  
> > I noticed that it is mentioned in the code, but I couldn't identify the use
> > case -- the icon of the license upload looks different. Is this code still
> > in use?
> 
> The icon is displayed after sending the license mail
> Welcome! > Request a new license > enter the email address and send the
> license

Thanks! Then we need to replace it with an alternative with a free license.

I suggest to use a normal "success" icon instead to avoid waiting for a new custom icon.
Comment 8 Florian Best univentionstaff 2023-12-13 11:21:20 CET
(In reply to Ingo Steuwer from comment #0)
> The icon "licenseMail.svg" includes a limited usage license as it is derived
> from an Icon from "IconMonstr". The license may conflict with our business
> modell (it seems like re-distribution in a commercial product is not allowed
> without permission by the copyright holder). In addition, as it is no OSI
> compliant license, it hinders us to release our implementation on openCode.
We are doing the change, nevertheless for the future I want to know why we need to replace it. The icon itself says it can be used in commercial projects:

><!-- The icon can be used freely in both personal and commercial projects with no attribution required, but always appreciated. 
> You may NOT sub-license, resell, rent, redistribute or otherwise transfer the icon without express written permission from iconmonstr.com -->

I don't see the limits here, which would disallow us to use it?
Comment 9 Ingo Steuwer univentionstaff 2023-12-13 11:29:29 CET
(In reply to Florian Best from comment #8)
> (In reply to Ingo Steuwer from comment #0)
> > The icon "licenseMail.svg" includes a limited usage license as it is derived
> > from an Icon from "IconMonstr". The license may conflict with our business
> > modell (it seems like re-distribution in a commercial product is not allowed
> > without permission by the copyright holder). In addition, as it is no OSI
> > compliant license, it hinders us to release our implementation on openCode.
> We are doing the change, nevertheless for the future I want to know why we
> need to replace it. The icon itself says it can be used in commercial
> projects:
> 
> ><!-- The icon can be used freely in both personal and commercial projects with no attribution required, but always appreciated. 
> > You may NOT sub-license, resell, rent, redistribute or otherwise transfer the icon without express written permission from iconmonstr.com -->
> 
> I don't see the limits here, which would disallow us to use it?

The license restricts the usage as it restricts the re-distribution. This leads to two problems:

1. It is not OSI compliant as an OSI compatible OSS license must not limit the usage. We need OSI compliance to be part of openDesk (and other public sector projects).

2. The limitation of the re-distribution is a problem anyway as it is unspecific: one can understand our download servers, customer driven repositories or mirroring code to github already as re-distribution - do we need a written agreement for each mirror?
Comment 10 Iván.Delgado univentionstaff 2023-12-13 14:29:54 CET
univention-management-console.yaml
b503b52abc33 | Bug #56717: Replace icon licenseMail.svg

univention-management-console (12.0.32-2)
b503b52abc33 | Bug #56717: Replace icon licenseMail.svg
Comment 11 Iván.Delgado univentionstaff 2023-12-13 14:30:08 CET
Package: univention-management-console
Version: 12.0.32-2
Branch: ucs_5.0-0
Scope: errata5.0-6
Comment 12 Christian Castens univentionstaff 2023-12-14 12:02:15 CET
QA:
  OK: The icon licenseMail.svg that is shown in the UCS license import dialog in UMC was replaced with a new one that has an OSI compliant license
  OK: advisories