Bug 56866 – Samba Backup Failure Due to Symbolic Link Issue

Bug 56866 - Samba Backup Failure Due to Symbolic Link Issue


Summary:	Samba Backup Failure Due to Symbolic Link Issue

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Samba4
Version:	UCS 5.0
Hardware:	amd64 Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-5-errata
Assigned To:	Felix Botner
QA Contact:	Arvid Requate

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2023-11-22 19:24 CET by ageukes
Modified:	2023-11-29 14:56 CET (History)
CC List:	4 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	7: Crash: Bug causes crash or data loss
Who will be affected by this bug?:	3: Will affect average number of installed domains
How will those affected feel about the bug?:	4: A User would return the product
User Pain:	0.480
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2023111521000324, 2023110721000134
Bug group (optional):
Max CVSS v3 score:

Attachments
Patch aus dem Pastebin (751 bytes, patch) 2023-11-28 15:15 CET, Christina Scheinig	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Comment 1 Arvid Requate

2023-11-24 11:30:59 CET

A customer reported that /usr/sbin/univention-samba4-backup aborts with a traceback
in case there is a symlink in /var/lib/samba/sysvol/$(hostname -d)/scripts/

This additionally causes tempfiles below /tmp to quickly pile up.

Comment 2 Arvid Requate

2023-11-24 11:31:49 CET

For the primary issue I propose

https://git.knut.univention.de/univention/ucs-patches/-/commit/ce341a3a595170fcaa180a8ee9647c480d62b842

for the secondary issue I propose sth like

https://git.knut.univention.de/univention/ucs/-/commit/492228a7773b24928e6680ed8f136064bbe60fa4

Comment 4 Felix Botner

2023-11-27 15:20:27 CET

scope: ucs_5.0-0-errata5.0-5
src: samba
fix: 2:4.18.3-1A~5.0.0.202311271227


fixed by ignoring symbolic links in backup tool (30_bug-56866-handle-symlinks-in-offline-backup.quilt for samba 4.18.3-1)

Comment 5 Arvid Requate

2023-11-27 16:15:38 CET

Verified:
* functional test with symlink: no crash, symlink present in archive
* advisory
* test case

We should upstream the patch.

Comment 6 Christina Scheinig

2023-11-28 15:09:14 CET

A second customer has this issue, and the samba backup fails on two school slave servers.

Comment 7 Christina Scheinig

2023-11-28 15:15:48 CET

Created attachment 11153 [details]
Patch aus dem Pastebin

Comment 8 Iván.Delgado

2023-11-29 14:56:15 CET

<https://errata.software-univention.de/#/?erratum=5.0x891>