Bug 56904 – Failing to reset the SMB connections on a computer results in an exam that can't be stopped, which blocks other exams

Bug 56904 - Failing to reset the SMB connections on a computer results in an exam that can't be stopped, which blocks other exams


Summary:	Failing to reset the SMB connections on a computer results in an exam that ca...

Status:	NEW

Product:	UCS@school
Classification:	Unclassified
Component:	UMC - Computer room
Version:	unspecified
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	UCS@school maintainers
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2023-12-07 14:50 CET by J Leadbetter
Modified:	2024-01-17 13:09 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	1: Will affect a very few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.057
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2023112821000354
Bug group (optional):
Max CVSS v3 score:

Attachments
Patch to prevent an SMB reset failure from stopping the exam (906 bytes, patch) 2023-12-07 14:50 CET, J Leadbetter	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description J Leadbetter

2023-12-07 14:50:45 CET

Created attachment 11157 [details]
Patch to prevent an SMB reset failure from stopping the exam

When running an exam, if there is a failure while trying to kill the SMB process (see here: https://git.knut.univention.de/univention/ucsschool/-/blob/5.0/ucs-school-umc-computerroom/umc/python/computerroom/__init__.py?ref_type=heads#L966), this prevents the exam from starting up. Additionally, this leaves the exam in a half-started state, and room is still marked as being used by the exam, so new exams can't be started in the room. Additionally, the exam files don't get collected or otherwise cleaned up.

Attached is a simplistic patch that prevents an SMB failure from starting the exam. However, a better, more long-term solution would be to catch any failures during startup and perform a cleanup of the exam, files, and room.