Bug 57544 - App center runs joinscripts before configure scripts during upgrade
App center runs joinscripts before configure scripts during upgrade
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-8-errata
Assigned To: Julia Bremer
Felix Botner
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2024-08-26 15:47 CEST by Julia Bremer
Modified: 2024-08-28 15:29 CEST (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julia Bremer univentionstaff 2024-08-26 15:47:52 CEST
During an upgrade of a docker app,
the configure scripts are only called after the joinscript already run.

The reason is, that during the upgrade_docker step of the appcenter,
_install_new_app is run, with an argument that inhibits the run of the "configure" scripts.
But it still executes the joinscripts.
Only later, _configure is explicitly run alongside call_joinscripts.
But as the joinscript version was already executed, this won't do anything anymore.


This is very unexpected and different to what is documented in the ISV documentation and probably by mistake.

https://docs.software-univention.de/app-center/latest/en/configurations.html#upgrade-scripts
Comment 1 Julia Bremer univentionstaff 2024-08-27 16:42:18 CEST
We adjusted the code to skip both configure script and joinscript during the update of the image.
Only afterwards, both are run explicitely. 

0ac5207f22 Bug #57544: Skip configure and joinscripts during image update
Comment 2 Felix Botner univentionstaff 2024-08-27 16:57:42 CEST
OK 5.0-8 
- test
- univention-appcenter 9.0.12-2 
- yaml

OK 5.1-0
- univention-appcenter 10.0.12

OK 5.2-0
- univention-appcenter 11.0.9