Bug 57672 - enforce JPEG conversion for profile pictures
Summary: enforce JPEG conversion for profile pictures
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: UDM (Generic)
Version: UCS 5.0
Hardware: Other Linux
: P5 normal
Target Milestone: UCS 5.0-9-errata
Assignee: Marius Meschter
QA Contact: Arvid Requate
URL: univention/ucs!1261
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-14 18:07 CEST by Marius Meschter
Modified: 2025-03-21 13:54 CET (History)
5 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): External feedback
Customer ID:
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marius Meschter univentionstaff 2024-10-14 18:07:49 CEST 

    


    


      



        
          Comment 1
        

        
          Marius Meschter

        

        
            univentionstaff
        

        
          2024-10-14 18:56:15 CEST
        

      






univention-directory-manager-modules.yaml
6af700c0521d | Bug #57672: enforce JPEG conversion for all profile pictures

univention-directory-manager-modules (15.0.28-2)
6af700c0521d | Bug #57672: enforce JPEG conversion for all profile pictures
1832e749b744 | Bug #57672: add changelogs

    


    


      



        
          Comment 3
        

        
          Marius Meschter

        

        
            univentionstaff
        

        
          2024-10-16 09:07:13 CEST
        

      







univention-directory-manager-modules.yaml
292ff6e174ee | Bug #57672: don't re-encode jpegPhoto if already valid jpeg

univention-directory-manager-modules (15.0.28-4)
292ff6e174ee | Bug #57672: don't re-encode jpegPhoto if already valid jpeg

univention-directory-manager-modules (15.0.28-3)
45304734dfc7 | Bug #57672: adjust exceptions caught by jpegPhoto parse

ucs-test (10.0.23-16)
292ff6e174ee | Bug #57672: don't re-encode jpegPhoto if already valid jpeg

    


    


      



        
          Comment 4
        

        
          Marius Meschter

        

        
            univentionstaff
        

        
          2024-10-17 18:28:12 CEST
        

      






Revert 292ff6e174ee and go with the original commit. The tests have been adjusted to work with the now always re-encoded image.

    


    


      



        
          Comment 5
        

        
          Arvid Requate

        

        
            univentionstaff
        

        
          2024-10-21 12:43:19 CEST
        

      






95be04141ed | revert to re-encoding every image and adjust ucs-test cases to new behavior

Package: univention-directory-manager-modules
Version: 15.0.28-5
Branch: 5.0-0
Scope: errata5.0-9

6a069e5bfc4 | revert to re-encoding every image and adjust ucs-test cases to new behavior

Package: univention-directory-manager-modules
Version: 17.0.22
Branch: 5.2-0

Verified:
* Code review
* Package update
* ucs-test
* Merged to UCS 5.2-0
* Advisory

71221ed68e1 | Update "fix" version in advisory

    


    


      



        
          Comment 6
        

        
          Felix Botner

        

        
            univentionstaff
        

        
          2024-10-22 09:23:42 CEST
        

      






One of the S4 Connector tests (120sync_create_and_modify_ucs_user) fails now with:

EXECUTING: udm-test 'users/user' modify  --dn 'uid=fmsfcmll,cn=users,dc=AutoTest091c,dc=test' --set employeeNumber=neideqpj --set employeeType=xprheqpm --set shell=izmeeqpo --set unixhome=/icdceqpr/ --set title=ejfceqpw --set jpegPhoto=/9j/4AAQSkZJRgABAQEBLAEsAAD/4Se4 --append-option pki --set userCertificate=MIICEjCCAXsCAg36MA0GCSqGSIb3DQEBBQUAMIGbMQswCQYDVQQGEwJKUDEOMAwGA1UECBMFVG9reW8xEDAOBgNVBAcTB0NodW8ta3UxETAPBgNVBAoTCEZyYW5rNEREMRgwFgYDVQQLEw9XZWJDZXJ0IFN1cHBvcnQxGDAWBgNVBAMTD0ZyYW5rNEREIFdlYiBDQTEjMCEGCSqGSIb3DQEJARYUc3VwcG9ydEBmcmFuazRkZC5jb20wHhcNMTIwODIyMDUyNjU0WhcNMTcwODIxMDUyNjU0WjBKMQswCQYDVQQGEwJKUDEOMAwGA1UECAwFVG9reW8xETAPBgNVBAoMCEZyYW5rNEREMRgwFgYDVQQDDA93d3cuZXhhbXBsZS5jb20wXDANBgkqhkiG9w0BAQEFAANLADBIAkEAm/xmkHmEQrurE/0re/jeFRLl8ZPjBop7uLHhnia7lQG/5zDtZIUC3RVpqDSwBuw/NTweGyuP+o8AG98HxqxTBwIDAQABMA0GCSqGSIb3DQEBBQUAA4GBABS2TLuBeTPmcaTaUW/LCB2NYOy8GMdzR1mx8iBIu2H6/E2tiY3RIevV2OW61qY2/XRQg7YPxx3ffeUugX9F4J/iPnnu1zAxxyBy2VguKv4SWjRFoRkIfIlHX0qVviMhSlNy2ioFLy7JcPZb+v3ftDGywUqcBiVDoea0Hn+GmxZACg== --set initials=erhd --set physicalDeliveryOfficeName=rapierhg --set preferredDeliveryMethod=any --set preferredLanguage=eeryerho --append postOfficeBox=elcjerhj --append postOfficeBox=gfkverhl --append departmentNumber=svfrergs --append departmentNumber=qjnhergv --append roomNumber=ofmwergy --append roomNumber=txuterhb
(2024-10-21 11:34:35.521745) Invalid syntax: Picture of the user (JPEG format): Failed to convert file into JPEG format.

-> https://jenkins2022.knut.univention.de/view/Active/job/UCS-5.0/job/UCS-5.0-9/job/S4Connector/41/cfg=master-s4connector/testReport/52_s4connector/120sync_create_and_modify_ucs_user/master091c/