Bug 57802 - univention-app update-check iterates over the wrong apps during preup.sh
Summary: univention-app update-check iterates over the wrong apps during preup.sh
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: App Center
Version: UCS 5.0
Hardware: Other Linux
: P5 normal
Target Milestone: UCS 5.0-9-errata
Assignee: Dirk Wiesenthal
QA Contact: Felix Botner
URL: https://git.knut.univention.de/univen...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-11 15:14 CET by Dirk Wiesenthal
Modified: 2024-12-18 16:52 CET (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 3: A User would likely not purchase the product
User Pain: 0.103
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID:
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2024-12-11 15:14:38 CET 
When using

  univention-app update-check --ucs-version 5.1

in the preup.sh during the 5.0->5.1 upgrade, the tool may not report all broken apps. Because it uses the App Cache from 5.1 at this point. And 5.1 does not take 4.4 Docker Apps into account. Example to reproduce:

root@primary:~# univention-app info
UCS: 5.0-9 errata1187
Installed: 4.4/prometheus=2.35.0-5
Upgradable:
Comment 1 Dirk Wiesenthal univentionstaff 2024-12-11 15:17:11 CET 
Possible result: The administrator can upgrade to UCS 5.2 - losing the information that Prometheus is installed and no easy way to recover from that state. An app upgrade is probably somehow possible but not without manual intervention.
Comment 2 Dirk Wiesenthal univentionstaff 2024-12-11 15:25:11 CET 
Fixed in

Package: univention-appcenter
Version: 9.0.13-3
Branch: ucs_5.0-0-errata5.0-9
Scope: errata5.0-9

univention-appcenter (9.0.13-3)
c08cd7811c56 | Bug #57802:  did not report all missing apps during a UCS upgrade. Some docker apps may be missed due to working on the wrong cache. This has been fixed.


Backported to 5.1 and 5.2
Comment 3 Dirk Wiesenthal univentionstaff 2024-12-11 23:00:51 CET 
Extending the bug: Now that we have a correct univention-app update-check, we see that the Updater UMC module is flawed: As docker apps are no "native updater components", the page still gets a list of potential UCS releases. We want to hide these as there is no valid release update until all docker apps are up-to-date and released for the next UCS version.
Comment 4 Dirk Wiesenthal univentionstaff 2024-12-11 23:06:54 CET 
univention-updater.yaml
5f1dfb58a737 | Bug #57802: Do not provide the option to update to a new UCS release if some docker apps are not yet released for that release.

univention-updater (15.0.18-2)
5f1dfb58a737 | Bug #57802: Do not provide the option to update to a new UCS release if some docker apps are not yet released for that release.

univention-appcenter.yaml
38d573204396 | Bug #57802: YAML


Merged to 5.1 and 5.2 as well
Comment 5 Felix Botner univentionstaff 2024-12-12 14:43:13 CET 
- OK release update is blocked if apps are not available in next version
- OK 5.1 note is show before update
- OK update works
- OK 5.0-9 
  univention-updater 15.0.18-3
  univention-appcenter 9.0.13-3
- OK merged to 5.1/5.2
- OK yaml