Description Sönke Schwardt-Krummrich 2025-05-06 18:07:26 CEST

Logic error in UCS@school lib:

ucs-school-lib/modules/ucsschool/lib/models/group.py:

---[cut]---
class _MayHaveSchoolSuffix(object):
    def get_relative_name(self):  # type: () -> str
        # schoolname-1a => 1a
        if (
            self.school
            and self.name.lower().endswith("-%s" % self.school.lower())
            or self.name.lower().endswith(" %s" % self.school.lower())
        ):
            return self.name[: -(len(self.school) + 1)]
        return self.name
---[cut]---

If self.school is None, the code will throw a traceback because "and" has higher priority than "or". Currently the code semantically looks like this:

        if (
            (self.school and self.name.lower().endswith("-%s" % self.school.lower()))
            or self.name.lower().endswith(" %s" % self.school.lower())
        ):

but it should be

        if self.school and (
            self.name.lower().endswith("-%s" % self.school.lower())
            or self.name.lower().endswith(" %s" % self.school.lower())
        ):