Bug 33092
| Summary: | Missing error handling for archive upload | ||
|---|---|---|---|
| Product: | UCS | Reporter: | Alexander Kläser <klaeser> |
| Component: | Sysinfo | Assignee: | Florian Best <best> |
| Status: | CLOSED FIXED | QA Contact: | Drees Dormann <dormann> |
| Severity: | normal | ||
| Priority: | P5 | CC: | best, gohmann, walkenhorst, wiesenthal |
| Version: | UCS 3.2 | ||
| Target Milestone: | UCS 4.0-0-errata | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| See Also: | https://forge.univention.org/bugzilla/show_bug.cgi?id=31192 | ||
| What kind of report is it?: | --- | What type of bug is this?: | --- |
| Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
| User Pain: | Enterprise Customer affected?: | ||
| School Customer affected?: | ISV affected?: | ||
| Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
| Ticket number: | Bug group (optional): | Usability | |
| Max CVSS v3 score: | |||
When any error occurs in the module the module just answers with "module process error, error message of the server was: None". e.g. if the server (forge) is unreachable, or the upload fails, ... Instead the reason should be printed. The standby animation should stop. Tracebacks should be logged. And in some cases a traceback would also be good so that the user can instead first sent that to univention. It sucks if error reporting fails. I fixed the error handling during working on univention-system-info. * Standby animations are reset if an error occurs * It's not possible anymore to use various filesystem paths for the upload (e.g. /etc/shadow or /etc/ldap.secret). * Errors are logged and sent to the frontend in a more user friendly way Fix: svn r56968, svn r56969 YAML: 2014-12-18-univention-system-info.yaml fixed , error handling looks good Upon failure Page now shows "Update failed" YAML OK |
In case the upload fails, the module process seems to fail due to missing error handling. In the UMC wizard, the standby animation stays for forever. > File "/usr/sbin/univention-management-console-module", line 112, in <module> > notifier.loop() > File "/usr/lib/pymodules/python2.6/notifier/nf_generic.py", line 284, in loop > step() > File "/usr/lib/pymodules/python2.6/notifier/nf_generic.py", line 271, in step > not __sockets[ cond ][ fd ]( sock_obj ): > File "/usr/lib/pymodules/python2.6/univention/management/console/protocol/modserver.py", line 129, in _recv > data = socket.recv( RECV_BUFFER_SIZE ) > error: [Errno 104] Die Verbindung wurde vom Kommunikationspartner zur?ckgesetzt