Univention Bugzilla – Full Text Bug Listing |
Summary: | "Save" should indicate modified state | ||
---|---|---|---|
Product: | UCS | Reporter: | Philipp Hahn <hahn> |
Component: | UMC (Generic) | Assignee: | Florian Best <best> |
Status: | CLOSED FIXED | QA Contact: | Johannes Keiser <keiser> |
Severity: | normal | ||
Priority: | P5 | CC: | best, gohmann, klaeser, schwardt, walkenhorst, wiesenthal |
Version: | UCS 4.0 | ||
Target Milestone: | UCS 4.0-0-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
See Also: | https://forge.univention.org/bugzilla/show_bug.cgi?id=31884 | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | Usability | |
Max CVSS v3 score: | |||
Bug Depends on: | 37592 | ||
Bug Blocks: | 37711 |
Description
Philipp Hahn
2014-11-14 13:55:28 CET
Yes, that would be very cool! The save button is now disabled until a change was done. It is disabled again when the state is the same as the original state. Fix: svn r57205 YAML: 2015-01-08-univention-management-console-module-udm.yaml *** Bug 32286 has been marked as a duplicate of this bug. *** (In reply to Alexander Kläser from comment #3) > *** Bug 32286 has been marked as a duplicate of this bug. *** Wrong bug. *** Bug 26215 has been marked as a duplicate of this bug. *** (In reply to Alexander Kläser from comment #5) > *** Bug 26215 has been marked as a duplicate of this bug. *** Could you then also prompt a hint if changes will be discarded? As discussed, we will opt for the following solution: * If values are initially set by UMC (i.e., combo boxes with no empty value will preselect the first value in the list), a popup will notify that there are some values which will be selected automatically. * Saving is always possible, no matter whether there are changes or not. * When values are changed (manually or automatically), a popup will be displayed when trying to close the page without saving. * Inform about automatically set default values when opening a object. * Ask for closing the detailpage if changes to the object have been done. Fix: svn r57370 YAML: 2015-01-08-univention-management-console-module-udm.yaml (In reply to Florian Best from comment #8) > * Inform about automatically set default values when opening a object. > * Ask for closing the detailpage if changes to the object have been done. > Fix: svn r57370 > YAML: 2015-01-08-univention-management-console-module-udm.yaml Looks great! Creating a new user: > udm users/user create --set username=test --set lastname=Test --set password=testpwd. I then receive the following message when opening the user in UMC: > The following empty properties were set to default values in the form. These values will be applied when saving. > * [Advanced settings] - Windows terminal server - CTX RAS Dialin: Disabled > * [Advanced settings] - Remote mail retrieval - Protocol: IMAP This looks fine to me. On the tab [Advanced settings], there is another hierarchy level, e.g., for the first point it would be: > Windows terminal server - Connection - CTX RAS Dialin But I find it OK to leave it at this, otherwise the lines will become longer. There is only one change that I would request, please change the order of the buttons in the dialogue "There are unsaved changes. Are you sure to cancel?" [ Discard changes ] [ Continue editing ] See also: > http://uxmovement.com/buttons/why-ok-buttons-in-dialog-boxes-work-best-on-the-right/ fixed. In DetailPage::_notifyAboutAutomaticChanges():
> if (item.id == value) { value = item.label; }
This may be problematic as value might match another ID a second time. Well, for this case here, this is relatively unlikely and not really critical, so I will ignore this ;) .
Changes: OK
YAML entry: OK
Package version: OK, I updated it
There is still one issue: It does not work if there is no group in the layout (this is the case when having zarafa installed). Fixed in svn r57604. Package currently builds. Changes: OK YAML: OK |