Bug 36700 - "Save" should indicate modified state
"Save" should indicate modified state
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.0-0-errata
Assigned To: Florian Best
Johannes Keiser
:
: 26215 (view as bug list)
Depends on: 37592
Blocks: 37711
  Show dependency treegraph
 
Reported: 2014-11-14 13:55 CET by Philipp Hahn
Modified: 2015-02-06 11:06 CET (History)
6 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Usability
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2014-11-14 13:55:28 CET
Clicking on the "save" (btw: who still knows what a floppy-disk is?) print the notification "No changes have been made". It always required an additional click, which is bad ad the floppy image is quiet small and the okay button is in a complete different location, before next the small cancel button has to be found again.

Instead the icon could be disabled (grayed out or whatever is currently state-of-the-UI-art) so the user can see if any setting are modified.
Comment 1 Florian Best univentionstaff 2014-11-14 14:08:08 CET
Yes, that would be very cool!
Comment 2 Florian Best univentionstaff 2015-01-08 17:55:01 CET
The save button is now disabled until a change was done.
It is disabled again when the state is the same as the original state.

Fix: svn r57205
YAML: 2015-01-08-univention-management-console-module-udm.yaml
Comment 3 Alexander Kläser univentionstaff 2015-01-13 13:08:55 CET
*** Bug 32286 has been marked as a duplicate of this bug. ***
Comment 4 Alexander Kläser univentionstaff 2015-01-13 13:09:42 CET
(In reply to Alexander Kläser from comment #3)
> *** Bug 32286 has been marked as a duplicate of this bug. ***

Wrong bug.
Comment 5 Alexander Kläser univentionstaff 2015-01-13 13:11:38 CET
*** Bug 26215 has been marked as a duplicate of this bug. ***
Comment 6 Alexander Kläser univentionstaff 2015-01-13 13:12:04 CET
(In reply to Alexander Kläser from comment #5)
> *** Bug 26215 has been marked as a duplicate of this bug. ***

Could you then also prompt a hint if changes will be discarded?
Comment 7 Alexander Kläser univentionstaff 2015-01-13 14:39:06 CET
As discussed, we will opt for the following solution:
* If values are initially set by UMC (i.e., combo boxes with no empty value will preselect the first value in the list), a popup will notify that there are some values which will be selected automatically.
* Saving is always possible, no matter whether there are changes or not.
* When values are changed (manually or automatically), a popup will be displayed when trying to close the page without saving.
Comment 8 Florian Best univentionstaff 2015-01-19 16:10:37 CET
* Inform about automatically set default values when opening a object.
* Ask for closing the detailpage if changes to the object have been done.
Fix: svn r57370
YAML: 2015-01-08-univention-management-console-module-udm.yaml
Comment 9 Alexander Kläser univentionstaff 2015-01-22 15:15:46 CET
(In reply to Florian Best from comment #8)
> * Inform about automatically set default values when opening a object.
> * Ask for closing the detailpage if changes to the object have been done.
> Fix: svn r57370
> YAML: 2015-01-08-univention-management-console-module-udm.yaml

Looks great! Creating a new user:

> udm users/user create --set username=test --set lastname=Test --set password=testpwd.

I then receive the following message when opening the user in UMC:

> The following empty properties were set to default values in the form. These values will be applied when saving.
> * [Advanced settings] - Windows terminal server - CTX RAS Dialin: Disabled
> * [Advanced settings] - Remote mail retrieval - Protocol: IMAP

This looks fine to me. On the tab [Advanced settings], there is another hierarchy level, e.g., for the first point it would be:

> Windows terminal server - Connection - CTX RAS Dialin

But I find it OK to leave it at this, otherwise the lines will become longer.

There is only one change that I would request, please change the order of the buttons in the dialogue "There are unsaved changes. Are you sure to cancel?"
  [ Discard changes ]  [ Continue editing ]
See also:
> http://uxmovement.com/buttons/why-ok-buttons-in-dialog-boxes-work-best-on-the-right/
Comment 10 Florian Best univentionstaff 2015-01-22 15:17:55 CET
fixed.
Comment 11 Alexander Kläser univentionstaff 2015-01-22 15:36:24 CET
In DetailPage::_notifyAboutAutomaticChanges():

> if (item.id == value) { value = item.label; }

This may be problematic as value might match another ID a second time. Well, for this case here, this is relatively unlikely and not really critical, so I will ignore this ;) .

Changes: OK
YAML entry: OK
Package version: OK, I updated it
Comment 12 Florian Best univentionstaff 2015-01-27 13:09:47 CET
There is still one issue: It does not work if there is no group in the layout (this is the case when having zarafa installed).
Comment 13 Florian Best univentionstaff 2015-01-27 13:13:37 CET
Fixed in svn r57604. Package currently builds.
Comment 14 Johannes Keiser univentionstaff 2015-01-27 16:02:57 CET
Changes: OK
YAML: OK
Comment 15 Janek Walkenhorst univentionstaff 2015-01-29 11:45:44 CET
<http://errata.univention.de/ucs/4.0/62.html>