Bug 48989

Summary: 26univention-samba.inst passes value of /etc/machine.secret unquoted
Product: UCS Reporter: Arvid Requate <requate>
Component: SambaAssignee: Daniel Tröder <troeder>
Status: CLOSED FIXED QA Contact: Arvid Requate <requate>
Severity: normal    
Priority: P5 CC: best, troeder
Version: UCS 4.4   
Target Milestone: UCS 4.4-0-errata   
Hardware: Other   
OS: Linux   
See Also: https://forge.univention.org/bugzilla/show_bug.cgi?id=48992
What kind of report is it?: Bug Report What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 2: Will only affect a few installed domains How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.069 Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional):
Max CVSS v3 score:
Attachments: fix-quoting-26univention-samba.inst

Description Arvid Requate univentionstaff 2019-03-14 10:58:52 CET
Created attachment 9923 [details]
fix-quoting-26univention-samba.inst

In 26univention-samba.inst the machine.secret is not quoted when storing it in samba ("smbpasswd -w" and "net idmap secret"). See attached patch.
Comment 1 Daniel Tröder univentionstaff 2019-03-14 12:58:19 CET
Applied patch, replaced $(cat ..) with $(< ..) for fewer forks.

[4.4-0 876e35f2c0] Bug #48989: fix quoting
[4.4-0 75374c548b] Bug #48989: advisory

univention-samba (13.0.0-2)
Comment 2 Arvid Requate univentionstaff 2019-03-14 13:28:38 CET
Verified:
* Code review
* Advisory & binary package version
Comment 3 Arvid Requate univentionstaff 2019-03-20 12:29:28 CET
<http://errata.software-univention.de/ucs/4.4/11.html>