Univention Bugzilla – Bug 33737
Check UCS code for localization of standard accounts like "Administrator"
Last modified: 2020-08-12 16:18:11 CEST
We need a ucslint check for use of the custom_groupname in source code (templates, scripts etc.). Basically for each use of a well known group name like "Domain Users" it needs to be checked that it finally gets translated via $(custom_groupname "<UCS Well Known Group Name>") or custom_groupname("<UCS Well Known Group Name>, ucr) into a name customizable via the UCR variable family groups/default/.* (e.g. groups/default/domainusers="Domänen-Benutzer"). There need to be well defined exceptions from this rule, like univention-config-registry set 'auth/nagios/group/Domain Admins?yes' where the untranslated use of UCS Well Known Group Names is required. Note: I think Bug 33736 would be a useful prerequisite for these exceptions. +++ This bug was initially created as a clone of Bug #33649 +++
custom_username also needs to be covered.
univention-pam and univention-nagios-server use configRegistry.groupNameMapping and configRegistry.userNameMapping instead in the /etc/security/*.conf templates.
*** Bug 41502 has been marked as a duplicate of this bug. ***
Created attachment 7734 [details] Rough check for common AD names in ucslint I attached a first version of a test script that was in use on my notebook for about 1 year. It is not complete, but maybe it can start as a base for an improved version.
The module ID "9017" should be renamed back to "0017" or somethink like that. I increased it, to have no conflict between my beta versions and already existing ucslint modules.
This issue has been filed against UCS 3. UCS 3 is out of the normal maintenance and many UCS components have vastly changed in UCS 4. If this issue is still valid, please change the version to a newer UCS version otherwise this issue will be automatically closed in the next weeks.
This issue has been filed against UCS 4.2. UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed. If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.
Added as 0008-7 (In reply to Arvid Requate from comment #0) > There need to be well defined exceptions from this rule,... > Note: I think Bug 33736 would be a useful prerequisite for these exceptions. This is not yet implemented, but 0008-7 can be added to debian/ucslint.overrides instead for now to disable false positives.
[4.4-5] dd5f1986f6 Bug #51637 et al: Merge branch 'phahn/ucslint' into 4.4-5 [4.4-5] 27097e04ab Bug #33736 ucslint: Add PEP 484 type annotation [4.4-5] ead929786f Bug #33736 ucslint: Remove pylint controls [4.4-5] 0bf963dfad Bug #51611 ucslint: Check for old upgrade code [4.4-5] aca8b0a080 Bug #33736 ucslint: Line specific overrides [4.4-5] 9ce142e02d Bug #51611 ucslint: Extract code for regular expressions [4.4-5] 9f728fe6ac Bug #34240 ucslint: Extract code for line regexp [4.4-5] a85d86edcd Bug #33736 ucslint: Rename UPCMessage arguments [4.4-5] 7b27fd592b Bug #33736 ucslint: Remove unused enumerate() [4.4-5] 152f7ec514 Bug #34240 ucslint: Fix PO flag regular expression [4.4-5] 523f573ec3 Bug #33736 ucslint: Fix mypy typing errors [4.4-5] 012e422a45 Bug #49240 ucslint: Print erroneous string [4.4-5] 4ba4649874 Bug #49240 ucslint: Update comments and documentation [4.4-5] fd133be24e Bug #49240 ucslint: Remove string formatting [4.4-5] 25b91c7c65 Bug #51106 ucslint: Check for debian/*.pyinstall usage [4.4-5] 5922fab3d7 Bug #49704 ucslint: Fix unicode handling [4.4-5] 690e03f824 Bug #51107 ucspep8: Fix duplicate entry [4.4-5] 0d94850650 Bug #28284 ucslint: Allow python3 [4.4-5] f700589a05 Bug #33737 ucslint: Check for well-known SIDs [4.4-5] 73b8b1cf62 Bug #49240 ucslint: re-indent [4.4-5] dfcfc5bcdb Bug #49240 ucslint: isort [4.4-5] b1cb194e6a Bug #99999 ucslint: Check for reserved Python words [4.4-5] 6105b4fa68 Bug #51612 ucslint: Check for more shell issues [4.4-5] 914c042673 Bug #49620 ucslint: Check debian/changelog for errors [4.4-5] 24b01261c3 Bug #49240 ucslint: Fix filter logic [4.4-5] 1292292dba Bug #51246 ucslint: Ignore more debian/ files [4.4-5] d9c6841a93 Bug #49240 ucslint: Allow ucslint on multiple packages [4.4-5] de8635cf9f Bug #49240 ucslint: Improve sorting Package: ucslint Version: 8.0.0-19A~4.4.0.202008060958 Branch: ucs_4.4-0 Scope: errata4.4-5 [4.4-5] c3fddf7b9c Bug #51612: ucslint 8.0.0-19A~4.4.0.202008060958 doc/errata/staging/ucslint.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
OK: git:f700589a05a1ab3a6870cdb5f7d183745900bdad OK: advisory
<https://errata.software-univention.de/#/?erratum=4.4x708>