Univention Bugzilla – Bug 51611
Check for old upgrade code
Last modified: 2023-11-16 11:47:53 CET
Our debian/*.{pre,post}{inst,rm} maintainer scripts often contain code which is only executed on package upgrades from previous versions. Debian's policy is to remove such old code in release+1 as releases cannot be skipped. The same applies to UCS and we also should remove those old code blocks. ucslint should check for cases, where `dpkg --compare-versions "$2" <OP> <VER>` is used and `VER` is lower then the major version from `debian/changelog`.
[4.4-5] dd5f1986f6 Bug #51637 et al: Merge branch 'phahn/ucslint' into 4.4-5 [4.4-5] 27097e04ab Bug #33736 ucslint: Add PEP 484 type annotation [4.4-5] ead929786f Bug #33736 ucslint: Remove pylint controls [4.4-5] 0bf963dfad Bug #51611 ucslint: Check for old upgrade code [4.4-5] aca8b0a080 Bug #33736 ucslint: Line specific overrides [4.4-5] 9ce142e02d Bug #51611 ucslint: Extract code for regular expressions [4.4-5] 9f728fe6ac Bug #34240 ucslint: Extract code for line regexp [4.4-5] a85d86edcd Bug #33736 ucslint: Rename UPCMessage arguments [4.4-5] 7b27fd592b Bug #33736 ucslint: Remove unused enumerate() [4.4-5] 152f7ec514 Bug #34240 ucslint: Fix PO flag regular expression [4.4-5] 523f573ec3 Bug #33736 ucslint: Fix mypy typing errors [4.4-5] 012e422a45 Bug #49240 ucslint: Print erroneous string [4.4-5] 4ba4649874 Bug #49240 ucslint: Update comments and documentation [4.4-5] fd133be24e Bug #49240 ucslint: Remove string formatting [4.4-5] 25b91c7c65 Bug #51106 ucslint: Check for debian/*.pyinstall usage [4.4-5] 5922fab3d7 Bug #49704 ucslint: Fix unicode handling [4.4-5] 690e03f824 Bug #51107 ucspep8: Fix duplicate entry [4.4-5] 0d94850650 Bug #28284 ucslint: Allow python3 [4.4-5] f700589a05 Bug #33737 ucslint: Check for well-known SIDs [4.4-5] 73b8b1cf62 Bug #49240 ucslint: re-indent [4.4-5] dfcfc5bcdb Bug #49240 ucslint: isort [4.4-5] b1cb194e6a Bug #99999 ucslint: Check for reserved Python words [4.4-5] 6105b4fa68 Bug #51612 ucslint: Check for more shell issues [4.4-5] 914c042673 Bug #49620 ucslint: Check debian/changelog for errors [4.4-5] 24b01261c3 Bug #49240 ucslint: Fix filter logic [4.4-5] 1292292dba Bug #51246 ucslint: Ignore more debian/ files [4.4-5] d9c6841a93 Bug #49240 ucslint: Allow ucslint on multiple packages [4.4-5] de8635cf9f Bug #49240 ucslint: Improve sorting Package: ucslint Version: 8.0.0-19A~4.4.0.202008060958 Branch: ucs_4.4-0 Scope: errata4.4-5 [4.4-5] c3fddf7b9c Bug #51612: ucslint 8.0.0-19A~4.4.0.202008060958 doc/errata/staging/ucslint.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
OK: git:9ce142e02d4a9a40b05dd7abbeddb3ac0f0ab537 OK: git:0bf963dfada493fd0857d0f236ee4ebe5ca4d9cb OK: advisory
<https://errata.software-univention.de/#/?erratum=4.4x708>
[5.0-5] 708e5f5d73 refactor(print): Remove old upgrade code services/univention-printserver/debian/univention-printserver.postinst | 20 -------------------- 1 file changed, 20 deletions(-) [5.0-5] 125cce6038 refactor(app-appliance): Remove old upgrade code .../debian/univention-app-appliance.postinst | 40 ----------------------------- 1 file changed, 40 deletions(-) [5.0-5] 886d729c12 fix(ucslint): detection of old Debian maintainer script chunks packaging/ucslint/debian/changelog | 6 ++++++ packaging/ucslint/testframework/0018-5.correct | 2 ++ packaging/ucslint/testframework/0018-5/debian/ucslint.postinst | 6 ++++++ packaging/ucslint/univention/ucslint/0018-Debian.py | 5 +++-- 4 files changed, 17 insertions(+), 2 deletions(-) Package: ucslint Version: 9.0.3-3 Branch: ucs_5.0-0 Scope: errata5.0-5