Bug 45109 - (lsb41) Missing LSB tags in univention-services ("insserv: warning: script missing LSB tags")
(lsb41)
Missing LSB tags in univention-services ("insserv: warning: script missing LS...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Update - Release updates
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-4-errata
Assigned To: Janek Walkenhorst
Jürn Brodersen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-01 11:59 CEST by Janek Walkenhorst
Modified: 2018-01-09 09:48 CET (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 6: Setup Problem: Issue for the setup process
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.514
Enterprise Customer affected?: Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2017072821000491
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janek Walkenhorst univentionstaff 2017-08-01 11:59:51 CEST
A few univention-* services are missing the LSB header in their init-script.

This can lead to problems when insserv is called to migrate to dependency based boot during the update to 4.2-0.

We should identify those init-scripts and add the headers (e.g. from the 4.2 init script) as an erratum for 4.1-4 to the scripts.
Comment 1 Philipp Hahn univentionstaff 2017-08-04 14:43:51 CEST
FYI: You can pick the patches from Bug #38438:
$ git l1 --grep 'Bug #38438'
e155cb8719 Bug #38438 adc/s4c: start-stop-daemon --oknodo
f336aee41c Bug #38438 adc/s4c: start-stop-daemon --oknodo
a920b7bd99 Bug #43306 test: Remove test for insserv
8d82baf7aa Bug #38438 dhcp: Fix init script
b19bf18fd2 Bug #38438 adc: Make init-script LSB compliant
5d403b0688 Bug #38438,Bug #36571 base: Make init scripts executable
32957e92cc Bug #38438 udl: Fix log message
93c0e89af3 Bug #38438: Fix use of get_lsb_header_val
dfc970eb49 Bug #38438 et al: insserv ChangeLog
af6cff9ac4 Bug #38438 udn: Make init-script LSB compliant
3fcae7972c Bug #38438 welcome: Make init-script LSB compliant
ef7033941f Bug #38438 server: Make init-script LSB compliant
1207b60b1f Bug #38438 docker: Make init-script LSB compliant
fdd76b3009 Bug #38438 cloud: Make init-script LSB compliant
27e70db2f2 Bug #38438 log: Make init-script LSB compliant
5fe410fb20 Bug #38438 welcome: Make init-script LSB compliant
7582fb2b55 Bug #38438 uss: Make init-script LSB compliant
fee39e9f8b Bug #38438 saml: Make init-script LSB compliant
788b832fa4 Bug #38438 up: Make init-script LSB compliant
c9d7db8e9d Bug #38438 policy: Make init-script LSB compliant
082283f1ab Bug #38438 adc: Make init-script LSB compliant
e983f4c45b Bug #38438 s4c: Make init-script LSB compliant
cbaa6d12a6 Bug #38438 smb: Make init-script LSB compliant
74f3d1fe0f Bug #38438 neti: Make init-script LSB compliant
1877969793 Bug #38438 demo: Make init-script LSB compliant
16ae42566b Bug #38438 kvm: Make init-script LSB compliant
db9d9da4c3 Bug #38438 uvmm: Make init-script LSB compliant
dc7d549117 Bug #38438 dhcp: Make init-script LSB compliant
b54b568ebb Bug #38438 runit: Make init-script LSB compliant
ff3cf8bd59 Bug #38438 fw,net: Make init-script LSB compliant
5b8f69374c Bug #38438,Bug #42339,Bug #42340 umc: Make init-script LSB compliant
052d753f5d Bug #38438 net: Make init-script LSB compliant
cf4572ac1c Bug #38438 bind: Make init-script LSB compliant
819bbb417c Bug #38438 udn: Make init-script LSB compliant
181519a8aa Bug #38438 udl: Make init-script LSB compliant
bd76b1008f Bug #38438 base: Make init-script rdate LSB compliant
91c3b7fe77 Bug #38438 base: Remove klogd for dependency based boot
Comment 2 Janek Walkenhorst univentionstaff 2017-08-09 14:57:21 CEST
univention-ad-connector.yaml
univention-base-files.yaml
univention-bind.yaml
univention-bootsplash.yaml
univention-cloud-init.yaml
univention-directory-listener.yaml
univention-directory-notifier.yaml
univention-directory-policy.yaml
univention-docker-container-mode.yaml
univention-docker-container.yaml
univention-firewall.yaml
univention-log-collector.yaml
univention-management-console-frontend.yaml
univention-management-console.yaml
univention-network-manager.yaml
univention-runit.yaml
univention-s4-connector.yaml
univention-saml.yaml
univention-system-setup.yaml
univention-updater.yaml
univention-virtual-machine-manager-node.yaml
Comment 3 Jürn Brodersen univentionstaff 2017-08-11 11:29:54 CEST
Looks good to me.
What I tested:
Updated 4.1-4 System
Upgraded the system to 4.2-1
Reboot
systemctl status -> OK

YAML -> OK

Verified
Comment 4 Jürn Brodersen univentionstaff 2017-08-11 11:37:12 CEST
One think I noticed:
The univention-system-setup-boot init script is not updated because univention-system-setup-boot is not installed.
I don't think that is a problem since it is not started anyway.