Univention Bugzilla – Bug 31026
Cleanup univention-server
Last modified: 2021-05-25 16:02:13 CEST
Created attachment 5165 [details] Cleanup Quoting Duplicated code Hard-coded LDAP port Wrap long lines Fix $LOG>> Simplify shell constructs check_connection | 42 +++-------- managed-client | 101 +++++++++++++--------------- mobile-client | 99 +++++++++++++--------------- server_password_change | 137 ++++++++++++++++++--------------------- univention-ldap-server-available | 27 ++----- 5 files changed, 180 insertions(+), 226 deletions(-) UNTESTED
This issue has been filed against UCS 3.1. UCS 3.1 is out of maintenance and many UCS components have vastly changed in later releases. Thus, this issue is now being closed. If this issue still occurs in newer UCS versions, please reopen.
The same broken code is still in UCS-4.2, except that - mobile- and managed-client are no longer present - server_password_change uses create_machine_password instead of mkpasswd
This issue has been filed against UCS 4.2. UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed. If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.
The package still contains substandard code after 7 years... check_connection is unused - it was for mobile/managed clients only univention-ldap-server-available needs work. server_password_change even more: - passes the password around on command line for everyone to see (Security) PS: /etc/machine.secret.SAVE is updated by univention-join, which uses "cat" to append the previous password, which does not end on a new-line. [feature/ucs5] f9a2ae1184 Bug #31026 server: Cleanup scripts base/univention-server/check_connection | 99 --------- base/univention-server/debian/changelog | 6 + base/univention-server/server_password_change | 230 +++++++++++---------- .../univention-ldap-server-available | 30 +-- .../server_password_change.d/README.API | 7 +- doc/changelog/changelog-5.0-0.xml | 2 +- 6 files changed, 141 insertions(+), 233 deletions(-) QA: ucr set server/password/interval=0 SPCDEBUG=1 bash ./server_password_change
https://taiga.knut.univention.de/project/oschwieg-ucs-5/task/5068?kanban-status=54
Verified: * Code review * Functional test a1d8090d78 | Fix changelog typo
UCS 5.0 has been released: https://docs.software-univention.de/release-notes-5.0-0-en.html https://docs.software-univention.de/release-notes-5.0-0-de.html If this error occurs again, please use "Clone This Bug".