Univention Bugzilla – Bug 32539
Check debian/*.{pre,post}{rm,inst} for wrong comment
Last modified: 2017-04-04 18:30:08 CEST
The preinst,postinst,prerm,postrm are often copied from previous packages or other files of the same package. In many cases the the comment is not updated, so a "postinst" script talks about itself being a "prerm" script. The attached simple tests checks if the scripts mentions one of the other script names # for m in */*; do PYTHONPATH=packaging/ucslint packaging/ucslint/bin/ucslint -m 1700 "$m"; done 2>/dev/null W:1700-1: base/univention-doc/debian/univention-doc.prerm: wrong script name: '# postinst script for univention-doc' W:1700-1: management/univention-legacy-kolab-schema/debian/univention-legacy-kolab-schema.prerm: wrong script name: '# postinst script for the debian package' W:1700-1: services/univention-pkgdb/debian/univention-pkgdb.postrm: wrong script name: '# prerm script for the debian package' W:1700-1: services/univention-postgresql/debian/univention-postgresql.postrm: wrong script name: '# postinst' W:1700-1: services/univention-s4-connector/debian/univention-s4-connector.postrm: wrong script name: '# postinst script of the samba4 connector package' W:1700-1: test/ucs-test/debian/ucs-test-framework.postrm: wrong script name: '# postinst script for the ucs-test-framework package'
Created attachment 5419 [details] ucslint check for correct script naming
Maybe there is a way to let this boilerplate to be created automatically? It's really non-functional and only of cosmetic importance.
r72026 | Bug #32539 ucslint: Warn about wrong script name comments Package: ucslint Version: 6.0.0-1A~4.2.0.201608301342 Branch: ucs_4.2-0 r72027 | Bug #32539,Bug #41926,Bug #37203: ucslint ucs-4.2-0/doc/changelog/changelog-4.2-0.xml
OK: Changelog OK: fix
UCS 4.2 has been released: https://docs.software-univention.de/release-notes-4.2-0-en.html https://docs.software-univention.de/release-notes-4.2-0-de.html If this error occurs again, please use "Clone This Bug".