Description Philipp Hahn 2016-08-08 11:52:54 CEST

Created attachment 7858 [details]
Unquotet use of local in UCS-4.1-3

"dash" in contrast to "bash" needs quoting for local function variables; otherwise the value is slit on IFS:

> $ dash -c 'f () { local var=$1; }; f "a-b.c-d a-b"'
> dash: 1: local: a-b: bad variable name
> $ dash -c 'f () { local var="$1"; }; f "a-b.c-d > a-b"'

This caused Bug #41917.

ucslint should check shell files for
  git grep -n "\<local\> \w\+=\([^\"'0-9 \$(]\|\$[^'?\$!#({]\|\${[^?\$!#]\)"

This is not perfect as "local" can be used to assign multiple local variables at once.

 $ dash -c 'f () { local var=`echo a-b.c-d a-b`; }; f "a-b.c-d > a-b"'
 dash: 1: local: a-b: bad variable name
 $ dash -c 'f () { local var="`echo a-b.c-d a-b`"; }; f "a-b.c-d > a-b"'