Bug 32543 - univention-add-app ignores ServerRole
univention-add-app ignores ServerRole
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 3.1
Other Linux
: P5 normal (vote)
: UCS 4.0-1-errata
Assigned To: Dirk Wiesenthal
Stefan Gohmann
:
Depends on:
Blocks: 32546
  Show dependency treegraph
 
Reported: 2013-09-10 16:24 CEST by Stefan Gohmann
Modified: 2015-03-11 15:07 CET (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Gohmann univentionstaff 2013-09-10 16:24:02 CEST
univention-add-app ignores the ServerRole setting from the ini file. For example:

$ grep ServerRole meta-inf/3.2/zarafa_XXXXXXX.ini 
ServerRole=domaincontroller_master,domaincontroller_backup,domaincontroller_slave

On a memberserver the command 'univention-add-app -a --latest zarafa' installs zarafa.
Comment 1 Dirk Wiesenthal univentionstaff 2013-11-19 16:30:16 CET
This is because tests are only run in UMC module, the script simply calls install().

Caveat when implemented: ServerRole=memberserver would prevent installation on DC master even when called only for master packages.

Maybe one could run the tests by default but ignore errors on --force?
Comment 2 Dirk Wiesenthal univentionstaff 2015-03-09 11:34:17 CET
Prevents app installation in
  univention-updater 10.0.53-10.1383.201503091126

Exception: If --master is given, the app is installed on DC Master/Backup anyway. Not a very likely exception, because apps probably are installable on a DC Master in any case, but this way it is more safer.
Comment 3 Stefan Gohmann univentionstaff 2015-03-10 14:47:29 CET
YAML: OK

Tests: OK

Code review: OK
Comment 4 Moritz Muehlenhoff univentionstaff 2015-03-11 15:07:06 CET
http://errata.univention.de/ucs/4.0/106.html