Comment 1 Stefan Gohmann 2014-10-06 09:24:47 CEST

*** Bug 36046 has been marked as a duplicate of this bug. ***

Comment 2 Dmitry Galkin 2014-11-03 16:48:54 CET

(In reply to Stefan Gohmann from comment #0)
> The test case introduced with Bug #31793 should consider the app role
> definition in the ini file. 

r55298:
  * 20_appcenter/17_app_status: new test version that considers App's server role
    (Bug #32546).

Comment 3 Dmitry Galkin 2014-11-03 16:52:32 CET

(In reply to Stefan Gohmann from comment #0)
> Alternative the ec2 tool aborts if the app could
> not be installed, therefore Bug #32543 must be fixed.

If this part is also assigned to me, please re-assign the Bug #32543 respectively.

Comment 4 Dirk Wiesenthal 2015-03-09 00:56:59 CET

Code Review:
As far as I understand the new test checks whether the server has the correct role and fails if this is not the case. This is more or less the opposite of what this bug should fix.
When testing on a, say, memberserver, while this role is not allowed, lots and lots of tests fail for whatever reason this role was disallowed. This bug should somehow skip the whole test suite, as those are all false positives. The app won't be installed on this server anyway.
Please correct me if I am wrong and somewhere the test suite stops.

Comment 5 Dmitry Galkin 2015-03-09 10:32:30 CET

(In reply to Dirk Wiesenthal from comment #4)
> Code Review:
> As far as I understand the new test checks whether the server has the
> correct role and fails if this is not the case. This is more or less the
> opposite of what this bug should fix.

Yes, the test will fail if the App is installed, but the .ini does not specify current role as suitable for this App.


> When testing on a, say, memberserver, while this role is not allowed, lots
> and lots of tests fail for whatever reason this role was disallowed. This
> bug should somehow skip the whole test suite, as those are all false
> positives. The app won't be installed on this server anyway.
> Please correct me if I am wrong and somewhere the test suite stops.

My understanding of the initial bug description was:

1. If the App is not allowed on the current server role -> the tests should be aborted by the ec2-tool, that's what Bug #32543 asks for, isn't it?

2. And this test 17_app_status checks that App was in fact not installed on a role it's not allowed.

> This bug should somehow skip the whole test suite

Please correct me if I got your point wrong, but you want one of the tests that's executed by testing framework to skip the other tests? That should be done on the lower level and I don't see the original description actually asking to do that.

@Stefan, perhaps you can also comment?

Comment 6 Dirk Wiesenthal 2015-03-10 09:40:56 CET

OK. Test fails when role is not allowed