Bug 32760 - Text changes in UMC modules (3)
Text changes in UMC modules (3)
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 3.2
Other Linux
: P5 normal (vote)
: UCS 4.0-1-errata
Assigned To: Alexander Kramer
Alexander Kläser
:
Depends on:
Blocks: 38621
  Show dependency treegraph
 
Reported: 2013-09-30 15:07 CEST by Dirk Wiesenthal
Modified: 2015-05-29 13:56 CEST (History)
4 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Typo/text changes
Max CVSS v3 score:


Attachments
updated wording in some admin/handlers-modules (526.59 KB, patch)
2014-06-13 09:57 CEST, Alexander Kramer
Details | Diff
Makefile will generate .po-files (3.61 KB, text/plain)
2014-06-13 12:27 CEST, Alexander Kramer
Details
new patch text changes (118.35 KB, patch)
2015-04-01 15:14 CEST, Alexander Kramer
Details | Diff
Screenshot of policy page (37.66 KB, image/png)
2015-04-15 15:35 CEST, Alexander Kläser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2013-09-30 15:07:21 CEST
With Bug#24727 closed, we continue here:

Bug#24727 changed a lot of wording in users/user. Those have to be merged in settings/usertemplate
Comment 1 Dirk Wiesenthal univentionstaff 2013-09-30 15:11:27 CEST
There are still some multi value fields with no plural label.

Computers:
Inventory number
MAC address
IP address
Forward zone for DNS entry
Reverse zone for DNS entry
DHCP service
Service
Zone for DNS alias

Users:
Private postal address
Comment 2 Dirk Wiesenthal univentionstaff 2013-09-30 15:15:08 CEST
Some multi values have just a plural label:

Computer:
Email addresses of Nagios contacts

This is not the way we do it elsewhere. Either rename this one to:
Email address(es) of Nagios contacts

or rename all other fields plural only (more work, but I stumble on these parentheses)
Comment 3 Alexander Kramer univentionstaff 2014-06-13 09:57:53 CEST
Created attachment 5954 [details]
updated wording in some admin/handlers-modules

changed the wording as given

+ settings/usertemplate.py:
updated the options[] in usertemplate.py e.g. 'secretary' gets the option 'person'
'secretary' got also the description 'Superior' as in users/user.py

+ admin/syntax.py:
updated the subsyntaxes of class dhcpEntry from 'DHCP service' to 'Service names'

+ added a Makefile:
po-files fpr the following directories will be generated, but beware of 'fuzzy'

modules/univention/admin/
modules/univention/admin/handlers/policies/
modules/univention/admin/handlers/users/
modules/univention/admin/handlers/shares/
modules/univention/admin/handlers/mail/
modules/univention/admin/handlers/groups/
modules/univention/admin/handlers/
modules/univention/admin/handlers/networks/
modules/univention/admin/handlers/legacy/policies/
modules/univention/admin/handlers/legacy/computers/
modules/univention/admin/handlers/kerberos/
modules/univention/admin/handlers/nagios/
modules/univention/admin/handlers/dns/
modules/univention/admin/handlers/computers/
modules/univention/admin/handlers/container/
modules/univention/admin/handlers/settings/
modules/univention/admin/handlers/dhcp/
Comment 4 Alexander Kramer univentionstaff 2014-06-13 09:59:06 CEST
> or rename all other fields plural only (more work, but I stumble on these
> parentheses)

did this - stumbled on the parentheses too
Comment 5 Alexander Kramer univentionstaff 2014-06-13 12:27:52 CEST
Created attachment 5955 [details]
Makefile will generate .po-files
Comment 6 Alexander Kramer univentionstaff 2014-06-26 11:07:28 CEST
patch assigned
Comment 7 Alexander Kläser univentionstaff 2015-03-04 21:24:18 CET
Could you please attach a minimal patch of your changes, this one is way too huge to revise.
Comment 8 Alexander Kramer univentionstaff 2015-04-01 15:14:21 CEST
Created attachment 6795 [details]
new patch text changes
Comment 9 Alexander Kläser univentionstaff 2015-04-02 11:17:46 CEST
This patch looks much better :) .

Remove the ':' ? :
"Zugriff begrenzen auf: Rechner, IP-Adresse oder Netz"
→ "Zugriff begrenzen auf Rechner, IP-Adresse oder Netz"

Error for settings/usertemplate:
-			short_description=_('Name'),
+			short_description=_('User name'),
→ 'Name' refers to the template name AFAIS, maybe it would be good to rename it to 'Template name' in order to be more specific and to avoid confusion.

Typo: "Windows-Hverzeichnis" → "Windows-Heimatverzeichnis"

Otherwise the changes look good :) . Please apply them to our SVN.
Comment 10 Alexander Kramer univentionstaff 2015-04-10 15:44:54 CEST
r59691
univention-directory-manager-modules (10.0.29-41)
debian/changelog: Bug #32760: adpated multi value labels

Successful build
Package: univention-directory-manager-modules
Version: 10.0.29-40.1308.201504101505 ==> not as expected / version bump
Branch: ucs_4.0-0
Scope: errata4.0-1
----

univention-directory-manager-modules (10.0.29-44) 
* Bug #32760: version bump

Successful build
Package: univention-directory-manager-modules
Version: 10.0.29-44.1309.201504101533
Branch: ucs_4.0-0
Scope: errata4.0-1
---

r59696
yaml file
Comment 11 Alexander Kläser univentionstaff 2015-04-15 15:35:56 CEST
Created attachment 6826 [details]
Screenshot of policy page

Hm... some translations do not seem correct (de/en + sg/pl).
Comment 12 Alexander Kläser univentionstaff 2015-04-15 16:08:17 CEST
Another one: dns/forward_zone → "IP-Adressen"
Comment 13 Alexander Kramer univentionstaff 2015-04-15 16:39:34 CEST
r59835
univention-directory-manager-modules (10.0.29-45) 
* Bug #32760: adapted some labels
M       modules/univention/admin/handlers/dns/de.po
M       modules/univention/admin/handlers/dns/forward_zone.py
M       modules/univention/admin/handlers/policies/de.po
M       debian/changelog

Successful build
Package: univention-directory-manager-modules
Version: 10.0.29-45.1310.201504151632
Branch: ucs_4.0-0
Scope: errata4.0-1

r59836:
yaml file
Comment 14 Alexander Kläser univentionstaff 2015-04-15 16:48:55 CEST
(In reply to Alexander Kramer from comment #13)
> r59835
> univention-directory-manager-modules (10.0.29-45) 
> * Bug #32760: adapted some labels
> M       modules/univention/admin/handlers/dns/de.po
> M       modules/univention/admin/handlers/dns/forward_zone.py
> M       modules/univention/admin/handlers/policies/de.po
> M       debian/changelog
> 
> Successful build
> Package: univention-directory-manager-modules
> Version: 10.0.29-45.1310.201504151632
> Branch: ucs_4.0-0
> Scope: errata4.0-1
> 
> r59836:
> yaml file

Changes: OK, look good now.
YAML: OK, minor adjustment in wording [r59836].
Comment 15 Janek Walkenhorst univentionstaff 2015-04-21 09:22:35 CEST
<http://errata.univention.de/ucs/4.0/154.html>