Bug 33949 – unify license check for UCS and UCS@school

Bug 33949 - (unify-license-check) unify license check for UCS and UCS@school

(unify-license-check)
Summary:	unify license check for UCS and UCS@school

Status:	RESOLVED INVALID

Product:	UCS
Classification:	Unclassified
Component:	UMC (Generic)
Version:	UCS 3.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 3.x
Assigned To:	UMC maintainers
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-01-20 09:04 CET by Florian Best
Modified:	2015-10-14 18:03 CEST (History)
CC List:	1 user (show)

See Also:	33681 30354 38103 38761 39230
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2014-01-20 09:04:06 CET

UCS and UCS@school have the same duplicated code to check for validity of the license and displaying appropriate error messages.

The code evaluates returncodes and detect therefore the license status.
This is error prone if the underlying license implementation changes.
E.g.: It caused Bug #33681.

The code should be moved from ucs-school-lib/python/schoolldap.py and univention-management-console-module-udm/umc/python/udm/__init__.py and udm_ldap.py into e.g. univention-lib.

Comment 1 Florian Best

2015-10-14 18:03:24 CEST

We don't check the license in UCS@school anymore. The unused code has been removed from schooldap.py in Bug #39230.
If we ever need it again we should use the cleaned up code from UDM and put it into univention-lib.