Bug 34507 - Clean up useless cache_entry "security-copy" code in univention-directory-listener
Clean up useless cache_entry "security-copy" code in univention-directory-lis...
Product: UCS
Classification: Unclassified
Component: Listener (univention-directory-listener)
UCS 3.2
All Linux
: P5 enhancement (vote)
: UCS 4.1-2-errata
Assigned To: Philipp Hahn
Arvid Requate
Depends on: 24273
  Show dependency treegraph
Reported: 2014-04-08 20:24 CEST by Arvid Requate
Modified: 2016-07-21 15:16 CEST (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:

Untested code removal (14.16 KB, patch)
2014-04-08 21:00 CEST, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate univentionstaff 2014-04-08 20:24:20 CEST
Since r28653 of Bug #24273 every handler already gets it own private copy, so there's no longer the need for the univention-directory-listener to generate a copy of the new cache_entry before passing the data to handlers_update.

This "security-copy" of the new (in memory) cache entry was introduced for Bug #21914, but that change did not isolate the modules from each other, it only protected the cache from rogue modules.

We should remove the "security-copy" code introduced via Bug #21914.

+++ This bug was initially created as a clone of Bug #34499 +++
Comment 1 Philipp Hahn univentionstaff 2014-04-08 21:00:57 CEST
Created attachment 5862 [details]
Untested code removal

FYI: through handler_exec -> handlers_argtuple -> handlers_entrydict each handler gets an individual copy of the old|new dictionaries, so it's guaranteed that no communication between the modules is possible.
Comment 2 Philipp Hahn univentionstaff 2016-06-07 18:10:18 CEST
r69897 | Bug #34507 UDL: Remove 'security-copy'
r69896 | Bug #34507 UDL: Fix wrong error message

Package: univention-directory-listener
Version: 10.0.0-11.315.201606071717
Branch: ucs_4.1-0
Scope: errata4.1-2

r69910 | Bug #22383,Bug #30227,Bug #30263,Bug #34324,Bug #34507,Bug #34738,Bug #3490,Bug #38696,Bug #39509,Bug #40600,Bug #41261: UDL YAML
Comment 3 Arvid Requate univentionstaff 2016-07-13 19:39:35 CEST
Code review: Ok
Advisory: Ok
Comment 4 Janek Walkenhorst univentionstaff 2016-07-21 15:16:03 CEST