Univention Bugzilla – Bug 35151
Test settings dialog of computerroom module
Last modified: 2015-11-02 12:22:32 CET
Within the computerroom there is a "settings" dialog that is able to restrict 1) internet access 1a) set a specific internet rule for the computers of the computerroom 1b) set a custom internet rule (whitelist) for the computers of the computerroom 1c) use default settings/no special internet settings 2) printer access 2a) give access to all printer shares (currently not possible due to Bug 35076) 2b) use default settings 2c) deny access to all printer shares 3) share access 3a) limit share access to the home share 3b) no limitation for the computers of the selected room. Please create one or more test scripts that test the 3 settings above. The script should create - a new OU - at least 2 new computerrooms - new computers that are member of one of the computerrooms (IP addresses have to be set!) - new test users The test scripts should verify that settings for one room do not interfere with settings of another room. All settings are dependent of the client's IP address. So the test script has to use the network loop from the ucs-test NetworkRedirector helper class for faking the client's IP address. The test script should also check, if the specified expiration time for the room settings is correctly utilized.
This test is devided into three test scripts: "23_computerroom_time_settings" to test the expiration time for one room: - Create new school, new teacher, two computers and a computer room. - change the settings of the room to be: new_settings = { 'customRule': '', 'printMode': 'none', 'internetRule': 'none', 'shareMode': 'home', 'period': now + 2 minutes } - check if atjob is created correctly. - check if the "valid until" is displayed correcetly. (Fails because of Bug #35195) - wait 2 mins then: - check atjobs. - check the currect settings. "22_computerroom_module" to test the change of settings in one room: - Create new school, new teacher, two computers and a computer room. - Calculate all the possible combinations of: rules = ['none', 'Kein Internet', 'Unbeschränkt', 'custom'] printmodes = ['default', 'all', 'none'] sharemodes = ['all', 'home'] - change the settings of the computer room over all these possible combinations. - For each change in the room settings: - check if the display values (UMCP get command). - check the behaviour (atq, internet access, share access, print access) for the first room. "27_computerroom_two_rooms_settings_interference" to test the effect of changing the settings in two rooms: - Create new school, teacher, two computers and two computer rooms. - Calculate all the possible combinations of: rules = ['none', 'Kein Internet', 'Unbeschränkt', 'custom'] printmodes = ['default', 'all', 'none'] sharemodes = ['all', 'home'] - change the settings of the first room over all these possible combinations. - For each change in the first room settings: - change the second room settings over all the possible combinations. - check if the display values (UMCP get command). - check the behaviour (atq, internet access, share access, print access) for the first room. - For now the test always passes, giving "FAIL ..." message in the place where it fails. This is done because the existence of other bugs: Bug #35195, Bug #35341, Bug #35408.
All test scripts file names changed to start with "22_".
The test script took 234, 267 and 124 minutes to finish during the last test runs. Please have a look, if there is potential to speed it up.
The test script should contain the following steps: Nr of total iterations over settings = 24 * 24 = 576 for (24) iteration: 1 - getting room1 old(original) settings * small improvemts is done by modifying the existing dictionary "room1_old_settings" instead of a creating new one. 2 - setting room1 3 - start another (24) iterations (inner loop) 1- set room1 (incase there was a change in room1 settings after changing room2 settings in a previous iteration) 2- set room2 3- check_settings (get request results) 4 -check_behavior: 1- check atjobs (average execution time = 0.0058564059 sec): if no change in settings → no atjob added. 2- check internetrules (average execution time = 0.4476046823 sec): check if the rule in control is the expected rule * This step included fetching the ban page every iteration is improved by fetching the ban page once before any iteration is done and pass it as a parameter. 3- check share behavior (average execution time = 3.1209804192 sec): if sharemode = 'all' → check chare access: home read → 0 home write → 0 marktplatz read → 0 marktplatz write → 0 if sharemode = 'home' → check chare access: home read → 0 home write → 0 marktplatz read → 1 marktplatz write → 1 4- check print behavior (average execution time = 1.5679674111 sec): if printmode = 'none': smbclient hardware printer → 1 smbclient hardware PDFDrucker → 1 if printmode = 'default': smbclient hardware printer → 0 smbclient hardware PDFDrucker → 0 if printmode = 'all': smbclient hardware printer → 0 smbclient hardware PDFDrucker → 0 5- clean folders: * (optional step to reduce the result of smbclient -c dir command) '/home/gsmitte/groups/Marktplatz/' '/home/%s/lehrer/%s/' % (school, teacher) I could not see how to improve performance more without affecting the functionality.
'download.univention.de' is used instead of 'univention.de'
script "22_computerroom_time_settings" is skipped until bug #35195 is fixed.