Bug 35195 - "valid until" value change does not take effect
"valid until" value change does not take effect
Status: RESOLVED WONTFIX
Product: UCS@school
Classification: Unclassified
Component: UMC - Computer room
UCS@school 3.2 R2
Other Linux
: P5 normal (vote)
: UCS@school 4.0.x
Assigned To: UCS@school maintainers
:
Depends on:
Blocks: 35151
  Show dependency treegraph
 
Reported: 2014-06-25 12:47 CEST by Ammar Najjar
Modified: 2019-02-05 21:20 CET (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ammar Najjar univentionstaff 2014-06-25 12:47:07 CEST
In computer room settings web interface:
Changing the "valid until" compobox value does not take effect.
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2014-06-30 17:24:33 CEST
The settings dialog suggest the end time of the current lesson. If the "valid until" time is changed, the correct value is sent via UMCP to the UMC server but afterwards if the settings are read, the old value is returned from the server.
Comment 2 Ammar Najjar univentionstaff 2014-08-20 11:34:48 CEST
The problem lies in the file: /usr/share/pyshared/univention/management/console/modules/computerroom/__init__.py

line 605 assigns period to be a lession object.

This modification removes the bug, but still need to look at the desired behavior if time = lesson.begin:

@@ -602,8 +602,10 @@
                        time = self._ruleEndAt.time()
                        for lesson in self._lessons.lessons:
                                if time == lesson.begin:
-                                       period = lesson
+                                       period = lesson.end # ← what is the desired behavior?
                                        break
+                       else:
+                               period = time
 
                self.finished(request.id, {
                        'internetRule' : rule,
Comment 3 Ammar Najjar univentionstaff 2014-12-15 10:32:24 CET
Please re-enable script "22_computerroom_time_settings" created for bug #35151 after this bug is fixed.
Comment 4 Sönke Schwardt-Krummrich univentionstaff 2019-02-05 21:20:46 CET
This issue has been filled against UCS@school 4.0. The maintenance with bug 
and security fixes for UCS@school 4.0 has ended on May 31, 2016.

Customers still on UCS 4.0 are encouraged to update to UCS 4.3 (or later). 
Please contact your partner or Univention for any questions.

If this issue still occurs in newer UCS versions, please use "Clone this bug"
or simply reopen the issue. In this case please provide detailed information on
how this issue is affecting you.