Bug 35463 - failing system setup scripts are silently ignored
failing system setup scripts are silently ignored
Status: REOPENED
Product: UCS
Classification: Unclassified
Component: System setup
UCS 5.0
Other Linux
: P5 normal with 3 votes (vote)
: UCS 3.x
Assigned To: UCS maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-24 13:01 CEST by Florian Best
Modified: 2020-07-15 18:57 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2015061121001098
Bug group (optional): Cleanup, Design, Error handling, External feedback, Usability
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2014-07-24 13:01:35 CEST
Currently failing system setup scripts are silently ignored.
This has the disadvantage that subsequent faults can happen and they are not recognized.

For example: the localization settings are failing for any reason. If this happens the 10interface script will also fail with a traceback like:
#########
Traceback (most recent call last):
  File "/usr/lib/univention-system-setup/scripts/30_net//10interfaces", line 36, in <module>
    from univention.management.console.modules.setup.setup_script import SetupScript, main, _
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/setup/setup_script.py", line 47, in <module>
    _ = setup_i18n()
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/setup/setup_script.py", line 44, in setup_i18n
    locale.setlocale(locale.LC_ALL, '')
  File "/usr/lib/python2.6/locale.py", line 513, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting
#########
Well, then we don't have any configured network interfaces. Every following script will of course fail then, too.

In the end the user will only see that the join failed because of a "missing dns service record for _domaincontroller_master._tcp.$domain".


1. Every failed system setup scripts should be mentioned in the error page of the UMC system setup wizard.

2.a) After one scripts fails no further scripts should be executed
2.b) Or there should be a specific return code which allows that further scripts are allowed to be executed.

IMHO 2.a. is the better solution. The system setup scripts should either implement a error handling and exit with 0 if errors occur which aren't critical (ofc nevertheless print some log output) or every script should check if the pre conditions are fulfilled (e.g. network connection exists)
Comment 1 Florian Best univentionstaff 2014-07-25 11:12:50 CEST
Another example is Bug #27276
Comment 2 Florian Best univentionstaff 2014-07-25 11:18:28 CEST
Antoher example is Bug #29511
Comment 3 Florian Best univentionstaff 2014-07-25 12:24:38 CEST
And another one Bug #29007
Comment 4 Florian Best univentionstaff 2014-07-29 11:06:36 CEST
And another one was described in Bug #27463 comment 3.
Comment 5 Alexander Kläser univentionstaff 2015-06-15 09:03:03 CEST
Still an issue with UCS 4.0. Has been reported at Ticket#2015061121001098.
Comment 6 Stefan Gohmann univentionstaff 2019-01-03 07:15:32 CET
This issue has been filled against UCS 4.0. The maintenance with bug and security fixes for UCS 4.0 has ended on 31st of May 2016.

Customers still on UCS 4.0 are encouraged to update to UCS 4.3. Please contact
your partner or Univention for any questions.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or simply reopen the issue. In this case please provide detailed information on how this issue is affecting you.
Comment 7 Florian Best univentionstaff 2020-07-15 18:57:46 CEST
Still an issue with UCS 5.0:

run-parts: executing /usr/lib/univention-system-setup/scripts/50_software/10software
=== 50_software/10software (2020-07-15 18:01:30) ===
__NAME__:50_software/10software Einrichten der Software-Komponenten
__STEPS__:1100
…

MSG__:Hole:12 http://omar.knut.univention.de/build2 ucs_5.0-0/all/ univention-s4-connector 14.0.0-4A~5.0.0.202007150004 [79,5 kB]
MSG__:96% [12 univention-s4-connector 34,8 kB/79,5 kB 43%]
MSG__:99% [Verarbeiten]
MSG__:Es wurden 937 kB in 0 s geholt (0 B/s)
ERR__:Fetching failed
ERR__:
ERR__:Further information regarding this error:
ERR__: - Filesize:17648 [weak].
ERR__: - MD5Sum:f5b987769bb9ea9b8cce684756299832 [weak].
ERR__:Failed to fetch http://omar.knut.univention.de/build2/ucs_5.0-0/amd64/libunivention-ldb-modules_8.0.0-2A~5.0.0.202007141820_amd64.deb Datei hat eine unerwartete Größe (17632 != 17648). Eventuell läuft gerade eine Spiegel-Synchronisierung? [IP: 192.168.0.10 80].
ERR__: - SHA512:4f688b3fdf5439c0ee600de3e4471ebb1dc01d71e4cb1f2c91f0e3e07c690871a8a712ad2bd6b11c93faa689de98341034bf25576bf342d8c6ba4ba074d304a9.
ERR__: - SHA1:2551bed7ece3eb9aaf79916846262b7ea5805c8d [weak].
ERR__:Hashes of expected file:.
ERR__: - SHA256:877cc6dc6ee58ada1f0a7b40de5bdc239f1c6740dd9bc7c42ce06d3ad0228d2c.
STEP__:0
MSG__:97% [Verarbeiten]
MSG__:97% [Verbindung mit omar.knut.univention.de]
MSG__:97% [Verbindung mit omar.knut.univention.de (192.168.0.10)]
MSG__:97% [Verbunden mit omar.knut.univention.de (192.168.0.10)]
MSG__:97% [Warten auf Kopfzeilen]
MSG__:Hole:13 http://omar.knut.univention.de/build2 ucs_5.0-0/amd64/ libunivention-ldb-modules 8.0.0-2A~5.0.0.202007141820 [17,6 kB]
MSG__:97% [13 libunivention-ldb-modules 0 B/17,6 kB 0%]
MSG__:Fehl http://omar.knut.univention.de/build2 ucs_5.0-0/amd64/ libunivention-ldb-modules 8.0.0-2A~5.0.0.202007141820
MSG__:Datei hat eine unerwartete Größe (17632 != 17648). Eventuell läuft gerade eine Spiegel-Synchronisierung? [IP: 192.168.0.10 80]
MSG__:Hashes of expected file:
MSG__: - SHA512:4f688b3fdf5439c0ee600de3e4471ebb1dc01d71e4cb1f2c91f0e3e07c690871a8a712ad2bd6b11c93faa689de98341034bf25576bf342d8c6ba4ba074d304a9
MSG__: - SHA256:877cc6dc6ee58ada1f0a7b40de5bdc239f1c6740dd9bc7c42ce06d3ad0228d2c
MSG__: - SHA1:2551bed7ece3eb9aaf79916846262b7ea5805c8d [weak]
MSG__: - MD5Sum:f5b987769bb9ea9b8cce684756299832 [weak]
MSG__: - Filesize:17648 [weak]
MSG__:97% [Verarbeiten]
MSG__:Es wurden 0 B in 0 s geholt (0 B/s)
ERR__:Fetching failed
ERR__:
ERR__:Further information regarding this error:
ERR__: - Filesize:17648 [weak].
ERR__: - MD5Sum:f5b987769bb9ea9b8cce684756299832 [weak].
ERR__:Failed to fetch http://omar.knut.univention.de/build2/ucs_5.0-0/amd64/libunivention-ldb-modules_8.0.0-2A~5.0.0.202007141820_amd64.deb Datei hat eine unerwartete Größe (17632 != 17648). Eventuell läuft gerade eine Spiegel-Synchronisierung? [IP: 192.168.0.10 80].
ERR__: - SHA512:4f688b3fdf5439c0ee600de3e4471ebb1dc01d71e4cb1f2c91f0e3e07c690871a8a712ad2bd6b11c93faa689de98341034bf25576bf342d8c6ba4ba074d304a9.
ERR__: - SHA1:2551bed7ece3eb9aaf79916846262b7ea5805c8d [weak].
ERR__:Hashes of expected file:.
ERR__: - SHA256:877cc6dc6ee58ada1f0a7b40de5bdc239f1c6740dd9bc7c42ce06d3ad0228d2c.
STEP__:0


Afterwards everything looks fine. All Jenkins Tests are executed and marked as green. With the only difference that no tests for univention-s4-connector ran.