Bug 41735 - univention-check-templates doesn't check the s4connector mapping file
univention-check-templates doesn't check the s4connector mapping file
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-3-errata
Assigned To: Philipp Hahn
Stefan Gohmann
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-07-05 17:26 CEST by Arvid Requate
Modified: 2017-11-02 15:26 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Troubleshooting
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate univentionstaff 2016-07-05 17:26:02 CEST
On a customer system we found these files which univention-check-templates didn't report (Ticket#2016063021000757):

/etc/univention/connector/s4/mapping.dpkg-dist
/etc/univention/templates/info/zarafa4ucs.info.dpkg-new
/etc/univention/templates/modules/zarafa-cfg.py.dpkg-new
/etc/pam.d/sshd.dpkg-new
Comment 1 Philipp Hahn univentionstaff 2016-10-10 14:09:55 CEST
(In reply to Arvid Requate from comment #0)
> On a customer system we found these files which univention-check-templates
> didn't report (Ticket#2016063021000757):

# whatis univention-check-templates
univention-check-templates (8) - list modified and not updated UCR templates

> /etc/univention/connector/s4/mapping.dpkg-dist

This is not a *UCR* template file at all.

> /etc/pam.d/sshd.dpkg-new

This is not the template file - this was created by "dpkg" because UCR modified the the original file as shipped by Debian.

> /etc/univention/templates/info/zarafa4ucs.info.dpkg-new
> /etc/univention/templates/modules/zarafa-cfg.py.dpkg-new

Those are not in "/etc/univention/templates/files/", so they're not template (but at least UCR related) files.
Comment 2 Arvid Requate univentionstaff 2016-10-10 21:07:38 CEST
Ok, I understand your point and I agree, that univention-check-templates might be the wrong place to check this.

But Ticket#2016063021000757 shows that the customer should have the possibility to check if some files are not updated due to local changes, that's why I created this bug.
Comment 3 Philipp Hahn univentionstaff 2016-10-17 11:03:24 CEST
Package: univention-config-registry
Version: 11.0.0-5.499.201610171052
Version: 11.0.0-5.500.201610171059
Branch: ucs_4.1-0
Scope: errata4.1-3

r73261 | Bug #41735 ucr: Check all files below /etc/univention/ YAML
r73260 | Bug #41735 ucr: Check all files below /etc/univention/
r73259 | Bug #41735 ucr: Check all files below /etc/univention/ YAML
r73258 | Bug #41735 ucr: Check all files below /etc/univention/
r73257 | Bug #41735 ucr: Check all files below /etc/univention/
 univention-config-registry.yaml
Comment 4 Philipp Hahn univentionstaff 2016-10-17 11:16:30 CEST
r73263 | Bug #41735 ucr: Check all files below /etc/univention/
r73262 | Bug #41735 ucr: Check all files below /etc/univention/

Package: univention-config-registry
Version: 11.0.0-5.501.201610171107
Branch: ucs_4.1-0
Scope: errata4.1-3

r73264 | Bug #41735 ucr: Check all files below /etc/univention/ YAML
 univention-config-registry.yaml

QA: install -D /dev/null /etc/univention/connector/s4/mapping.dpkg-dist
Comment 5 Philipp Hahn univentionstaff 2016-10-18 08:59:10 CEST
r73312 | Bug #41735 ucr: Check checking non-existing files
r73311 | Bug #41735 ucr: Check checking non-existing files

Package: univention-config-registry
Version: 11.0.0-6.502.201610180855
Branch: ucs_4.1-0
Scope: errata4.1-3

r73313 | Bug #41735 ucr: Check checking non-existing files YAML
Comment 6 Stefan Gohmann univentionstaff 2016-10-19 13:32:06 CEST
As discussed, I think we need a solution for univention-heimdal-kdc.cfg which is diverted by the univention-samba4 postinst:

root@master411:~# univention-check-templates 
WARNING: The following UCR files are modified locally.
Updated versions will be named FILENAME.dpkg-*.
The files should be checked for differences.

/etc/univention/service.info/services/univention-heimdal-kdc.cfg
root@master411:~# ls -la /etc/univention/service.info/services/univention-heimdal-kdc.cfg*
-rw-r--r-- 1 root root 203 Nov  3  2015 /etc/univention/service.info/services/univention-heimdal-kdc.cfg.disabled
-rw-r--r-- 1 root root 203 Mär 22  2016 /etc/univention/service.info/services/univention-heimdal-kdc.cfg.dpkg-new
root@master411:~#
Comment 7 Philipp Hahn univentionstaff 2016-10-19 14:57:47 CEST
r73357 | Bug #41735 ucr: Skip checking non-existing files

Package: univention-config-registry
Version: 11.0.0-7.503.201610191453
Branch: ucs_4.1-0
Scope: errata4.1-3

r73359 | Bug #41735 ucr: Skip checking non-existing files YAML
 univention-config-registry.yaml

r73358 | Bug #41735 ucr: Skip checking non-existing files
Comment 8 Stefan Gohmann univentionstaff 2016-10-19 17:25:19 CEST
Tests: OK

Merge: OK

YAML: OK
Comment 9 Janek Walkenhorst univentionstaff 2016-10-20 12:40:19 CEST
<http://errata.software-univention.de/ucs/4.1/294.html>