Univention Bugzilla – Bug 42173
The change password module should be integrated into the core
Last modified: 2017-04-04 18:29:12 CEST
The new menu in UMC should integrate the Change password module.
*** Bug 38901 has been marked as a duplicate of this bug. ***
Fixed. The module now just provides a hook module which adds a menu entry. The password is changed via a dialog. univention-management-console-module-passwordchange (2.0.2-2): r77015 | Bug #42173: fix typos + clean up hook module r76998 | Bug #42173: refactor passwordchange module as JavaScript hook
The menu entries now react dynamically on the login state. univention-management-console-module-passwordchange (2.0.2-3): r77072 | Bug #42173: show menu entry depending on login state
"Change password" in the menu does not get translated. related to bug 42263?
(In reply to Jürn Brodersen from comment #4) > "Change password" in the menu does not get translated. > related to bug 42263? I added the translations as well as the integration for l10n. We need to wait for Bug 43594 for the translations to be installed directly into the binary package. univention-management-console-module-passwordchange (2.0.2-5): r77336 | Bug #42173: add translations + l10n integration
Some minor stuff: * Clicking on change password does not focus the password input field. * I had an 8sec pause between changing the password and the success dialog, which was irritating ;) * I think the menu should be closed after changing the password What I tested: * Change Password on master and slave * The menu entry is only shown if logged in
(In reply to Jürn Brodersen from comment #6) > Some minor stuff: > * Clicking on change password does not focus the password input field. Fixed > * I had an 8sec pause between changing the password and the success dialog, > which was irritating ;) Hm... I did not have any problems so far. > * I think the menu should be closed after changing the password Fixed. univention-web (1.0.31-14): r77473 | Bug #42173: Focus first field in dialog.confirmForm() + return references univention-management-console-module-passwordchange (2.0.2-6): r77474 | Bug #42173: Close menu when launching password change dialog
(In reply to Alexander Kläser from comment #7) > (In reply to Jürn Brodersen from comment #6) > > Some minor stuff: > > * Clicking on change password does not focus the password input field. > > Fixed > Works > > * I had an 8sec pause between changing the password and the success dialog, > > which was irritating ;) > > Hm... I did not have any problems so far. > As discussed that is a problem in bigger domains and will not be fixed in the scope of this bug. > > * I think the menu should be closed after changing the password > > Fixed. > Works > univention-web (1.0.31-14): > r77473 | Bug #42173: Focus first field in dialog.confirmForm() + return > references > > univention-management-console-module-passwordchange (2.0.2-6): > r77474 | Bug #42173: Close menu when launching password change dialog I noticed on more thing :) If you have saved your password with chrome, chrome asks if you want to save the changed password for the user "X". Would it be possible to transmit the username as well, so chrome knows for which user the password was changed?
(In reply to Jürn Brodersen from comment #8) > I noticed on more thing :) > If you have saved your password with chrome, chrome asks if you want to save > the changed password for the user "X". Would it be possible to transmit the > username as well, so chrome knows for which user the password was changed? After the release if you open a new enhancement bug ;) ... but not now.
(In reply to Jürn Brodersen from comment #8) > > > * I had an 8sec pause between changing the password and the success dialog, > > > which was irritating ;) > > > > Hm... I did not have any problems so far. > > > As discussed that is a problem in bigger domains and will not be fixed in > the scope of this bug. Hm, can't we just add a this.standbyDuring() arround the blockign thing like tools.umcpCommand()?!
(In reply to Florian Best from comment #10) > (In reply to Jürn Brodersen from comment #8) > > > > * I had an 8sec pause between changing the password and the success dialog, > > > > which was irritating ;) > > > > > > Hm... I did not have any problems so far. > > > > > As discussed that is a problem in bigger domains and will not be fixed in > > the scope of this bug. > Hm, can't we just add a this.standbyDuring() arround the blockign thing like > tools.umcpCommand()?! The dialog closes itself on submit, so there isn't really anything to overlay with the standby animation (besides the whole page).
Looks good. -> Verified :) Note: The translations do not seem to work with our dev-build make target? The normal build is translated as expected.
The password change dialog does not honor the password policy.
(In reply to Daniel Tröder from comment #13) > The password change dialog does not honor the password policy. Please create a new bug for this. Which password policy are you referring to?
(In reply to Florian Best from comment #14) > (In reply to Daniel Tröder from comment #13) > > The password change dialog does not honor the password policy. > Please create a new bug for this. Which password policy are you referring to? The default password policy → Bug #44090.
UCS 4.2 has been released: https://docs.software-univention.de/release-notes-4.2-0-en.html https://docs.software-univention.de/release-notes-4.2-0-de.html If this error occurs again, please use "Clone This Bug".