Bug 42637 - Add tab for managing app translations
Add tab for managing app translations
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center - Self Service
UCS 4.1
Other Linux
: P5 normal (vote)
: ---
Assigned To: Johannes Keiser
Alexander Kläser
:
Depends on:
Blocks: 42635
  Show dependency treegraph
 
Reported: 2016-10-11 14:12 CEST by Alexander Kläser
Modified: 2016-11-25 10:01 CET (History)
2 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: Add tab for managing app translations
Bug group (optional):
Max CVSS v3 score:


Attachments
Mockup for translation view (502.69 KB, image/png)
2016-10-11 14:12 CEST, Alexander Kläser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2016-10-11 14:12:14 CEST
Created attachment 8084 [details]
Mockup for translation view

We will need a tab for properly handling app translations.
Comment 1 Alexander Kläser univentionstaff 2016-11-07 11:43:54 CET
A small snippet of sample code:
---------- 8< ----------
from univention.appcenter.actions import get_action
list_apps = get_action('selfservice-list')()
args = list_apps._build_namespace(
  username='Administrator',
  password='univention',
  noninteractive=True)
apps = list_apps.list_apps(args)
a = apps[0]
[i.name for i in a._attrs if i.localisable]
---------- 8< ----------
Comment 2 Alexander Kläser univentionstaff 2016-11-07 11:46:06 CET
The following bit of code gets the German translation of an app:
> app_de = a.get_app_cache_obj().copy(locale='de').find(app.id, app_version=app.version)
Comment 3 Dirk Wiesenthal univentionstaff 2016-11-07 11:47:49 CET
r74169 changed the default locale for SelfserviceApps to 'en'. Changelog in r74170
Comment 4 Alexander Kläser univentionstaff 2016-11-17 01:46:26 CET
The basic layout is up and working.

univention-management-console-module-appcenter-selfservice (1.0.0-104):
r74518 | Bug #42637: return only the changes of app translation properties
r74517 | Bug #42637: add tab with app translations

TODOs:
* The English READMEs are returned
* Saving the translation values does not work yet
* ThumbnailBox needs to support the properties value and disable
Comment 5 Dirk Wiesenthal univentionstaff 2016-11-17 23:55:25 CET
(In reply to Alexander Kläser from comment #4)
> TODOs:
> * The English READMEs are returned
> * Saving the translation values does not work yet

Done

> * ThumbnailBox needs to support the properties value and disable

What am I supposed to do here?
Comment 6 Alexander Kläser univentionstaff 2016-11-18 12:57:24 CET
(In reply to Dirk Wiesenthal from comment #5)
> (In reply to Alexander Kläser from comment #4)
> > TODOs:
> > * The English READMEs are returned
> > * Saving the translation values does not work yet
> 
> Done
> 
> > * ThumbnailBox needs to support the properties value and disable
> 
> What am I supposed to do here?
Comment 7 Alexander Kläser univentionstaff 2016-11-18 12:58:36 CET
(In reply to Dirk Wiesenthal from comment #5)
> (In reply to Alexander Kläser from comment #4)
> > TODOs:
> > * The English READMEs are returned
> > * Saving the translation values does not work yet
> 
> Done

Wonderful!

> 
> > * ThumbnailBox needs to support the properties value and disable
> 
> What am I supposed to do here?

Nothing, Johannes will adjust this behavior, along with setting labelPosition='top' in the widget's class and defining a label in AppUploadPage.
Comment 8 Alexander Kläser univentionstaff 2016-11-18 20:54:35 CET
(In reply to Alexander Kläser from comment #4)
> [...]
> * ThumbnailBox needs to support the properties value and disable

This will be done via Bug 43011. I added the correct labels, so German screenshots can be specified now.

univention-management-console-module-appcenter-selfservice (1.0.0-119):
r74590 | Bug #42637: Add correct label for screenshots widget
Comment 9 Dirk Wiesenthal univentionstaff 2016-11-18 21:18:36 CET
Upload limit for screenshots is 0.5 MB. This is not enough. We have screenshots > 2 MB. I do not see the need for a limit.
Comment 10 Alexander Kläser univentionstaff 2016-11-18 22:02:03 CET
(In reply to Dirk Wiesenthal from comment #9)
> Upload limit for screenshots is 0.5 MB. This is not enough. We have
> screenshots > 2 MB. I do not see the need for a limit.

fixed.

r74596 | Bug #42635: adjust size limit for screenshots
Comment 11 Alexander Kläser univentionstaff 2016-11-25 10:01:09 CET
The new version of the App Provider Portal has been released and this bug will thus be closed.