Bug 42800 – Add extra action to edit the META file of an app

Bug 42800 - Add extra action to edit the META file of an app


Summary:	Add extra action to edit the META file of an app

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	App Center - Self Service
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	Dirk Wiesenthal
QA Contact:	Alexander Kläser

URL:
Keywords:

Depends on:
Blocks:	42635
	Show dependency tree / graph

Reported:	2016-10-31 13:02 CET by Alexander Kläser
Modified:	2016-11-25 10:01 CET (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kläser

2016-10-31 13:02:53 CET

We will need the possibility to edit the corresponding meta file of an app. As there exists only 1 meta file per app and UCS version, it would make sense to offer via the context menu an additional action which opens a page with a form containing all fields of the meta file.

Comment 1 Dirk Wiesenthal

2016-11-14 01:12:52 CET

Added appcenter-selfservice/get_meta and appcenter-selfservice/save_meta. Don't know which format for save_meta. But adjusting that should be no problem.

Comment 2 Alexander Kläser

2016-11-14 10:02:41 CET

We still need the frontend part.

Comment 3 Alexander Kläser

2016-11-14 18:51:52 CET

The frontend part has been committed in a first version.

TODOs:
* Saving does not seem to work?
* Saving of logos does not work yet...

@Dirk: Can you have a look?

univention-management-console-module-appcenter-selfservice (1.0.0-80):
r74421 | Bug #42800: add action for editing the app's meta file

Comment 4 Dirk Wiesenthal

2016-11-15 01:08:01 CET

Fixed

Comment 5 Alexander Kläser

2016-11-15 09:34:30 CET

The [de] section is currently not respected...

Comment 6 Alexander Kläser

2016-11-15 10:24:38 CET

Fixed handling of logos as base64 encoded strings.

univention-management-console-module-appcenter-selfservice (1.0.0-84):
r74431 | Bug #42800: parse logos as base64 strings

TODOs:
* A meta file cannot be created for a new App:
 (1) create new App
 (2) edit meta information + save
 (3) get_meta still returns empty dict
* When saving a new logo, a traceback is shown
* The form is not reset when loading a new app. This is important as only the
  values which are given in the meta file are transmitted.

Comment 7 Alexander Kläser

2016-11-15 11:25:53 CET

(In reply to Alexander Kläser from comment #5)
> The [de] section is currently not respected...

The only translated elements are currently not in use, I removed them

(In reply to Alexander Kläser from comment #6)
> TODOs:
> [...]
> * The form is not reset when loading a new app. This is important as only the
>   values which are given in the meta file are transmitted.

Done.

univention-management-console-module-appcenter-selfservice (1.0.0-86):
r74436 | Bug #42800: adjust layout + remove unneeded elements + reset form

Comment 8 Alexander Kläser

2016-11-15 14:34:45 CET

@Dirk: ATM, I can upload a new logo and the file is created, however, the meta file does not contain an entry pointing to the file. Thus, re-opening the meta file, the logo will not be shown.

Otherwise, the behavior (with UCS 4.1-4 + staging errata scope) looks fine to me.

Comment 9 Dirk Wiesenthal

2016-11-18 00:05:49 CET

(In reply to Alexander Kläser from comment #8)
> @Dirk: ATM, I can upload a new logo and the file is created, however, the
> meta file does not contain an entry pointing to the file. Thus, re-opening
> the meta file, the logo will not be shown.

Works for me. Maybe temporary bug during development.

Comment 10 Alexander Kläser

2016-11-25 10:01:08 CET

The new version of the App Provider Portal has been released and this bug will thus be closed.