Bug 42803 - Track clicks on Buy button of Apps detail page
Track clicks on Buy button of Apps detail page
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 4.1
Other Linux
: P2 enhancement (vote)
: UCS 4.1-4-errata
Assigned To: Richard Ulmer
Dirk Wiesenthal
:
Depends on: 41690
Blocks:
  Show dependency treegraph
 
Reported: 2016-10-31 16:01 CET by Nico Gulden
Modified: 2017-01-11 12:19 CET (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Gulden univentionstaff 2016-10-31 16:01:58 CET
Bringing the transaction platform to life we would like to know, how many users click on the buy button on an app's detail page in the App Center. This is one entry point and it allows us to see where we loose the people on the way to the checkout in the shop.

Similar to the already available actions, please add a tracking for this.

+++ This bug was initially created as a clone of Bug #41690 +++

The backend should send a notification, just like after (un)installation, when the user clicks on the App in the Gallery.

Should only be tracked if the App is not yet installed anywhere.

If NotifyVendor=True, track license_uuid as 0000-0000-....

Please check whether the text regarding the notification is still valid.
Comment 1 Richard Ulmer univentionstaff 2016-12-16 14:37:05 CET
Clicking on the "Buy" button will now cause a tracking request to the back-end.
The code has also been refactored, so that the send_information() function now resides in python/appcenter/utils.py .

I also removed the check that was supposed to make sure that tracking is enabled, but wasn't implemented completely. Tracking is always enabled.

svn commit: 75348
Comment 2 Richard Ulmer univentionstaff 2016-12-16 14:54:48 CET
The package is now build and yaml file committed.

package: univention-appcenter
build  : 5.0.23-25.253.201612161438
svn commit: 75349
Comment 3 Richard Ulmer univentionstaff 2016-12-16 15:42:48 CET
I missed an error in a log-file previously. Did some additional fixing - should now work.

svn commit: 75351
build: 5.0.23-26.254.201612161539
svn commit (yaml): 75352
Comment 4 Florian Best univentionstaff 2016-12-20 11:37:43 CET
This is now done via a specific UMCP call. Shouldn't we do this via Piwik? (I am not sure).

At least the deactivation of such tracking is now ignored, so customers can't decide that they don't get tracked.
Comment 5 Dirk Wiesenthal univentionstaff 2016-12-21 02:16:14 CET
Why did you remove
  track = track !== false;

Was it buggy? This was supposed to disable "get" tracking for Apps already installed.

Also, no merge to 4.2

Buy tracking itself works.
Comment 6 Richard Ulmer univentionstaff 2016-12-21 14:17:14 CET
I had removed "track = track !== false;", because I was not able to see it's purpose and found that the track-parameter had weird values when I tested it. Through the help of Alex I can now see that it has purpose and put it back in.

I Also performed the merge to 4.2 .

svn commit (4.1-4): 75470
build (4.1-4)     : 5.0.23-29.256.201612211405
svn commit (yaml) : 75472

svn commit (4.2)  : 75471
build (4.2)       : 6.0.0-24A~4.2.0.201612211407
Comment 7 Richard Ulmer univentionstaff 2016-12-21 14:38:04 CET
I've added a comment explaining the track-parameter, to prevent someone else getting confused.

svn commit (4.1-4): 75473
svn commit (4.2)  : 75474
Comment 8 Dirk Wiesenthal univentionstaff 2017-01-09 18:05:20 CET
Changeset: OK
Merge: OK
YAML: OK
Comment 9 Janek Walkenhorst univentionstaff 2017-01-11 12:19:31 CET
<http://errata.software-univention.de/ucs/4.1/373.html>