Bug 42916 – The validation of all app values should be adjusted

Bug 42916 - The validation of all app values should be adjusted


Summary:	The validation of all app values should be adjusted

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	App Center - Self Service
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	Richard Ulmer
QA Contact:	Alexander Kläser

URL:
Keywords:

Depends on:
Blocks:	42635
	Show dependency tree / graph

Reported:	2016-11-10 12:04 CET by Alexander Kläser
Modified:	2016-11-25 10:01 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	Adjust form validation
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kläser

2016-11-10 12:04:49 CET

Currently, values that are not required are shown as required in the app view. Although values are shown as invalid, save will work ignore them and store the changes.

Comment 1 Dirk Wiesenthal

2016-11-12 23:05:06 CET

Not all attributes are editable. Listing them anyways.

Required: ['code', 'name', 'ucs_version', 'version', 'id', 'component_id']
Regex: [('code', '^[A-Za-z0-9]{2}$'),
 ('ports_redirection', '^\\d+:\\d+$'),
 ('required_ucs_version', '^(\\d+)\\.(\\d+)-(\\d+)(?: errata(\\d+))?$'),
 ('ports_exclusive', '^\\d+$'),
 ('id', '^[a-zA-Z0-9]+(([a-zA-Z0-9-_]+)?[a-zA-Z0-9])?$'),
 ('database_user', '(?!^(root)$|^(postgres)$)')]
IntAttribute: ['min_physical_ram', 'web_interface_port_http', 'web_interface_port_https']
Choices: [('web_interface_proxy_scheme', ['http', 'https', 'both']),
 ('supported_architectures', ['amd64', 'i386']),
 ('docker_server_role', ['memberserver', 'domaincontroller_slave']),
 ('server_role',
  ['domaincontroller_master',
   'domaincontroller_backup',
   'domaincontroller_slave',
   'memberserver']),
 ('ucs_overview_category', ['admin', 'service', None, False])]

These attributes _have to_ satisfy these contrainsts, otherwise the App will not be created by the code, ignoring this ini file completely!

Comment 2 Johannes Keiser

2016-11-18 16:46:32 CET

r 74584
univention-management-console-module-appcenter-selfservice (1.0.0-116) 
* Bug #42916: adjusted validation of app values

Comment 3 Alexander Kläser

2016-11-18 21:18:25 CET

Adjusted the validations and property "required".

univention-management-console-module-appcenter-selfservice (1.0.0-120):
r74591 | Bug #42916: Add/correct validations

Comment 4 Alexander Kläser

2016-11-18 22:36:22 CET

this._form.validate() is not called in the frontend when trying to save the current changes.

Comment 5 Richard Ulmer

2016-11-21 15:18:09 CET

this._form.validate() is now called and missing entrys are displayed, when trying to save. Also the galleryPage gets updated when saving now.

svn commit: 74645
build: 1.0.0-133.90.201611211516

Comment 6 Richard Ulmer

2016-11-21 16:02:06 CET

Updating the galleryPage didn't yet work as intended. Fixed now.

svn commit: 74648

Comment 7 Alexander Kläser

2016-11-25 10:01:08 CET

The new version of the App Provider Portal has been released and this bug will thus be closed.